-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix #309760: chord symbols realized before executing dialog
Resolves: https://musescore.org/en/node/309760 There is a command realize-chord-symbols that you can access from the tools menu or shortcut if you have defined it, and also a similarly item on the context menu for chord symbols. They are slightly differently, however - the command just runs, whereas the context menu brings up a dialog. Because they shared the same action, the context menu was actually executing both versions. This is fixed by creating a new action for the context menu. I reuse the name of the command but add an ellipsis, since it brings up a dialog. I suppose it's an open question why the behaviors should be different between invoking this from the Tools menu versus the context menu, but I'll wait until someone actually complains before changing it.
- Loading branch information
1 parent
f4c0004
commit d23fbf2
Showing
3 changed files
with
13 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters