Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic preceded by hairpin with dynamic ignored (dynamic added to the end of selected hairpin) #16381

Closed
tecc opened this issue Feb 15, 2023 · 21 comments
Assignees
Labels
needs info More information is required before action can be taken P3 Priority: Low playback General playback issue

Comments

@tecc
Copy link

tecc commented Feb 15, 2023

Describe the bug
When a dynamic is preceded by a hairpin with a dynamic, the hairpin's end dynamic "overrides" the specified dynamic.

To Reproduce
Steps to reproduce the behavior:

  1. Write some music (without dynamics, for now). Just a bunch of notes will do.
  2. Create a hairpin, and select it.
  3. Add a dynamic to the hairpin by pressing a dynamic from any palette.
  4. Add a dynamic after the hairpin is done, preferably a wildly contrasting one.
  5. Play.

Expected behavior
The playback reflects the dynamic for the new note(s).

Screenshots
image

2023-02-15.17-42-25.mp4

Platform information

  • OS: Linux (Ubuntu 22.04)
  • Reproduced in both stable and nightly versions, as well as using MS Basic
@cbjeukendrup cbjeukendrup added the P2 Priority: Medium label Feb 16, 2023
@zacjansheski

This comment was marked as outdated.

@zacjansheski zacjansheski self-assigned this Aug 18, 2023
@zacjansheski zacjansheski added the needs info More information is required before action can be taken label Aug 18, 2023
@tecc
Copy link
Author

tecc commented Aug 19, 2023

Yes. This is a reproduction on Windows.

2023-08-19.03-52-48.mp4

This is the MSCZ file (albeit zipped).

@zacjansheski
Copy link
Contributor

Ah, I see now, thank you for the mscz file!

@zacjansheski zacjansheski added playback General playback issue and removed needs info More information is required before action can be taken labels Aug 21, 2023
@zacjansheski zacjansheski added P1 Priority: High and removed P2 Priority: Medium labels Aug 21, 2023
@github-project-automation github-project-automation bot moved this to To triage in MuseScore 4.2 Aug 21, 2023
@DmitryArefiev
Copy link
Contributor

Yes, this occurs due to the way how dynamic (f) was added:

bandicam.2023-09-08.17-58-31-771.mp4

@DmitryArefiev DmitryArefiev changed the title [MU4 Issue] Dynamic preceded by hairpin with dynamic ignored [MU4 Issue] Dynamic preceded by hairpin with dynamic ignored (dynamic added to the end of selected hairpin) Sep 8, 2023
@DmitryArefiev
Copy link
Contributor

DmitryArefiev commented Nov 24, 2023

@bkunda I propose to bump this since it's not a regression even to MS3 and there is a workaround when adding a dynamic not to selected hairpin but to the note directly (as I showed above)

(please change it if disagree)

@tecc
Copy link
Author

tecc commented Nov 24, 2023

Sometimes you can't have dynamics on the next note like that.
For example, in this short "thing" I wrote the player is instructed to decrescendo from p to ppp and then play the next phrase/passage with the dynamic ff.
A few bars demonstrating a decrescendo from p to ppp, then switching to ff.

The suggested workaround would result in this unreadable mess, which also does not play back correctly.
A few bars demonstrating a decrescendo from p to some obscure dynamic. The obscure dynamic is in fact a combination of ff and ppp in the same spot

@tecc
Copy link
Author

tecc commented Nov 24, 2023

To clarify, I made the example in the previous comment for a clarinet, and there is a semantic difference between "this dynamic starts at the beginning of this note's duration" and "this dynamic starts at the end of this note's duration". This is also a difference that I would expect playback to represent.

@oktophonie
Copy link
Contributor

This is precisely one of the main issues to be fixed by #16796

@Dima-S-Jr
Copy link

I indicated the same thing in issue #20468

@bkunda

This comment was marked as resolved.

@bkunda bkunda added the needs info More information is required before action can be taken label May 17, 2024
@cbjeukendrup cbjeukendrup changed the title [MU4 Issue] Dynamic preceded by hairpin with dynamic ignored (dynamic added to the end of selected hairpin) Dynamic preceded by hairpin with dynamic ignored (dynamic added to the end of selected hairpin) May 17, 2024
@oktophonie oktophonie added P3 Priority: Low and removed P1 Priority: High labels May 28, 2024
@wizofaus

This comment was marked as outdated.

@Dima-S-Jr

This comment was marked as resolved.

@wizofaus

This comment was marked as outdated.

@Dima-S-Jr

This comment was marked as outdated.

@oktophonie

This comment was marked as outdated.

@wizofaus

This comment was marked as outdated.

@wizofaus

This comment was marked as outdated.

@wizofaus

This comment was marked as outdated.

@bkunda
Copy link

bkunda commented Jul 11, 2024

I believe this has now been resolved (can no longer reproduce).

N.B. I only changed the dynamic here because ppp was rendering so softly it was basically inaudible. Otherwise, no positional changes of any objects were made.

Example shows MS Basic (x2) then Muse Sounds:

Screen.Recording.2024-07-11.at.4.11.59.PM.mov

@bkunda bkunda closed this as completed Jul 11, 2024
@github-project-automation github-project-automation bot moved this from Issues to fix to Done in MuseScore Studio 4.4 Jul 11, 2024
@Dima-S-Jr
Copy link

I believe this has now been resolved (can no longer reproduce).

That's weird. In the test build from 12.07 I was unable to get the expected behavior. Instead, the loudness stopped changing at all according to the text at the end of the hairpin. Maybe I'm doing something wrong?

Video_240712114455.mp4

@oktophonie
Copy link
Contributor

Adding text to the end of hairpins is not the correct way to achieve what you want and using 'dynamics' in this way is not supported in 4.4.

However, with anchors you can achieve this properly by e.g. selecting a dynamic from the palette while the hairpin is selected (this puts a real dynamic at the end now, not a fake text dynamic) and then shunting it back to the end of the previous duration using Shift+Alt+Left, and then adding a dynamic on the new note:

Screen.Recording.2024-07-12.121044.mp4

However, fun fact, playback still doesn't work right; as this is issue is such a mess (and has been closed anyway) I've filed a clean version here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info More information is required before action can be taken P3 Priority: Low playback General playback issue
Projects
Development

No branches or pull requests

10 participants