Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #299387: support for screenreaders other than NVDA #5592

Commits on Dec 28, 2019

  1. fix #298887: rename Tin Whistle to C Tin Whistle for MusicXML Instrum…

    …entID wind.flutes.whistle.tin
    riaanvn committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    7180313 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    140b972 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b78f34 View commit details
    Browse the repository at this point in the history
  4. Filter shortcuts by current state because single key sequence may be …

    …used in various actions relative to current score state
    vpereverzev committed Dec 28, 2019
    Configuration menu
    Copy the full SHA
    242f7ab View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a1b9f29 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2019

  1. Configuration menu
    Copy the full SHA
    40095b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3aa3ec9 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Configuration menu
    Copy the full SHA
    d88c19f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    917d8b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. Specializes template routines.

    Qt 5.14 introduces serialisation/deserialisation for enum classes,
    this results in ambiguous templates between qdatastream.h and preferences.h.
    we specialize everything to workaround this.
    korli committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    09d1389 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b759bb View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. Configuration menu
    Copy the full SHA
    f02df10 View commit details
    Browse the repository at this point in the history
  2. move Tremolo Bar Properties into Inspector

    + fix one last problem in #53236
    Harmoniker1 committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    bb71758 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb72e37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    30b823c View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. fix MusicXML export part of #294815 - [Musicxml im-export] - New Tran…

    …sposition and pitches messed up
    lvinken committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    93a9443 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. support for xaphoon instrument

    Eduardo Rodrigues committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    3ff35f9 View commit details
    Browse the repository at this point in the history
  2. update instrument header file

    Eduardo Rodrigues committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    a9c80e3 View commit details
    Browse the repository at this point in the history
  3. fix #299387: support for screenreaders other than NVDA + collect_arti…

    …facts
    
    Most of the MuseScore GUI uses standard Qt widgets and thus is as accessible
    as one can reasonably expect - especially now that the palettes have moved to QML.
    The main issue thing preventing other screenreaders from being viable is the scoreview.
    The accessibility implementation made for the screenreader several years ago
    works for NVDA, but a number of small details prevent other screenreaders from working.
    This change addresses these, allowing JAWS to work relatively normally,
    and Windows Narrator to also work with a manual assist (Narrator + Tab shortcut).
    These changes don't adversely affect NVDA, and actually improve its response somewhat,
    fixing some of the mysterious "split button" texts that were being read.
    
    The changes here ar small but collectivey they make a difference,
    oth in getting JAWS and Narrator to work better out of the box,
    but also in making it easier to further script JAWS to provide enhanced accessibility.
    I used the Microsot Accessibility Insights tool to find and debug many of these issues.
    
    - added object names and accessible text for the container objects in the main window
    - fixed the rect() returned by the scoreview to use global screen coordinates
    - gave the AccessibleScoreView a role() of StaticText rather than NoRole
    - allow Description as well as Value as keys to access the accessibility text()
    - allow Qt to determine the window() for the AccessibleScoreView
    - override isValid() to be sure it always returns true
    
    Tese changes allow assistive tools to better associate events with objects,
    and objects with windows, which is necessary in order for things to work reliably.
    Otherwise, there were cases where the assistive tools would be unable
    to find the correct object or window.
    
    Most of the changes should be completely non-controversial and harmless at worst.
    The change from NoRole to StaticText yielded best results after trying quite a few options.
    This was the only meaningful role read by Windows Narrator at all,
    and one of the few recognized as valid and by Accessibility Insights.
    
    There are still cases where the screenreader can get confused about the current/active object,
    Sometimes it can be useful to press Alt twice (transfer focus to menu bar and back).
    But things seem *much* better with these changes, in my testing.
    MarcSabatella committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    5b4e1e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Configuration menu
    Copy the full SHA
    7118cdf View commit details
    Browse the repository at this point in the history
  2. Improve Split Staff dialogue

    Align the text on the left and make the size policy of spin box "Expanding".
    Harmoniker1 committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    6459e33 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. Configuration menu
    Copy the full SHA
    47dae68 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2fc0e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. Merge pull request musescore#5575 from Howard-C/fingering-style

    [Inspector/Regression] fix #299072: style setting for fingering in Inspector has no items
    dmitrio95 authored Jan 9, 2020
    Configuration menu
    Copy the full SHA
    50cbdcb View commit details
    Browse the repository at this point in the history
  2. Merge pull request musescore#5583 from korli/qt5.14

    fix build with Qt5.14
    dmitrio95 authored Jan 9, 2020
    Configuration menu
    Copy the full SHA
    8b9a81e View commit details
    Browse the repository at this point in the history
  3. Merge pull request musescore#5556 from riaanvn/298887-whistle.tin.c

    fix #298887: generic wind.flutes.whistle.tin is ambiguous
    dmitrio95 authored Jan 9, 2020
    Configuration menu
    Copy the full SHA
    245cd3f View commit details
    Browse the repository at this point in the history
  4. Assign a name for plugins actions

    Makes running plugins from menu be visible by a telemetry. Running
    plugins via shortcuts still remains untracked.
    dmitrio95 committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    3fc5790 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    90895e0 View commit details
    Browse the repository at this point in the history
  6. Compare shortcut state through the bitwise AND, because single shortc…

    …ut can work with multiple states
    vpereverzev committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    efced91 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1c323d7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0ecf84d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2912558 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    679708e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Configuration menu
    Copy the full SHA
    3da97f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ac7d26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    87c14c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2020

  1. Adjust highlight color for palettes

    After commit 41e64aa
    dmitrio95 committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    3997e1f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f362731 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2020

  1. Configuration menu
    Copy the full SHA
    3e40e9b View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Merge pull request musescore#5597 from Jojo-Schmitz/french_soprano_clef

    Fix #299518: Add "Soprano Clef (French, 20th/18th century)"
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    16ab5e1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request musescore#5601 from Jojo-Schmitz/harmonicas-ranges

    fix #299545: Incorrect Harmonicas Ranges
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    90c0759 View commit details
    Browse the repository at this point in the history
  3. Merge pull request musescore#5595 from Howard-C/properties-inside-panel

    [Inspector] Move "Properties" buttons inside inspector panels
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    de1dede View commit details
    Browse the repository at this point in the history
  4. Merge pull request musescore#5593 from Howard-C/split-staff

    Improve Split Staff dialogue
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    c29b06b View commit details
    Browse the repository at this point in the history
  5. Merge pull request musescore#5589 from lvinken/294815-musicxml-export…

    …-transpose-multi-instrument
    
    fix MusicXML export part of #294815 - [Musicxml im-export] - New Tran…
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    7efbe85 View commit details
    Browse the repository at this point in the history
  6. Merge pull request musescore#5576 from Jojo-Schmitz/ptb

    fix #44796: enable ptb import
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    7bc323b View commit details
    Browse the repository at this point in the history
  7. Merge pull request musescore#5585 from Howard-C/tremolo-bar-properties

    [Inspector] move Tremolo Bar Properties into Inspector (fix #53236)
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    46de751 View commit details
    Browse the repository at this point in the history
  8. Merge pull request musescore#5591 from eduardomourar/feature/add-xaph…

    …oon-instrument
    
    Support for xaphoon instrument
    anatoly-os authored Jan 13, 2020
    Configuration menu
    Copy the full SHA
    e5ec5e5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    23a3d20 View commit details
    Browse the repository at this point in the history
  10. Fix new Pocket-Saxes

    Jojo-Schmitz committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    bd80864 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Configuration menu
    Copy the full SHA
    a35d658 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c9cc19 View commit details
    Browse the repository at this point in the history
  3. fix #297719: AppImage: add more libraries

    New files bundled in AppImage:
    
    - libcupsprintersupport.so - Qt printsupport plugin
    - libnss3.so - a fallback for Chromebook devices
    - findlibs - tiny C program to check system libraries
    shoogle committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    21ba231 View commit details
    Browse the repository at this point in the history
  4. Merge pull request musescore#5607 from shoogle/appimage-libraries

    fix #297719: AppImage: add more libraries
    dmitrio95 authored Jan 14, 2020
    Configuration menu
    Copy the full SHA
    8eb74bb View commit details
    Browse the repository at this point in the history
  5. Update copyright

    Harmoniker1 committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    39a7cbd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    385f33e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f79fff7 View commit details
    Browse the repository at this point in the history
  8. fix #299387: support for screenreaders other than NVDA + collect_arti…

    …facts
    
    Most of the MuseScore GUI uses standard Qt widgets and thus is as accessible
    as one can reasonably expect - especially now that the palettes have moved to QML.
    The main issue thing preventing other screenreaders from being viable is the scoreview.
    The accessibility implementation made for the screenreader several years ago
    works for NVDA, but a number of small details prevent other screenreaders from working.
    This change addresses these, allowing JAWS to work relatively normally,
    and Windows Narrator to also work with a manual assist (Narrator + Tab shortcut).
    These changes don't adversely affect NVDA, and actually improve its response somewhat,
    fixing some of the mysterious "split button" texts that were being read.
    
    The changes here ar small but collectivey they make a difference,
    oth in getting JAWS and Narrator to work better out of the box,
    but also in making it easier to further script JAWS to provide enhanced accessibility.
    I used the Microsot Accessibility Insights tool to find and debug many of these issues.
    
    - added object names and accessible text for the container objects in the main window
    - fixed the rect() returned by the scoreview to use global screen coordinates
    - gave the AccessibleScoreView a role() of StaticText rather than NoRole
    - allow Description as well as Value as keys to access the accessibility text()
    - allow Qt to determine the window() for the AccessibleScoreView
    - override isValid() to be sure it always returns true
    
    Tese changes allow assistive tools to better associate events with objects,
    and objects with windows, which is necessary in order for things to work reliably.
    Otherwise, there were cases where the assistive tools would be unable
    to find the correct object or window.
    
    Most of the changes should be completely non-controversial and harmless at worst.
    The change from NoRole to StaticText yielded best results after trying quite a few options.
    This was the only meaningful role read by Windows Narrator at all,
    and one of the few recognized as valid and by Accessibility Insights.
    
    There are still cases where the screenreader can get confused about the current/active object,
    Sometimes it can be useful to press Alt twice (transfer focus to menu bar and back).
    But things seem *much* better with these changes, in my testing.
    MarcSabatella committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    60512d5 View commit details
    Browse the repository at this point in the history
  9. additional object names

    MarcSabatella committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    bfc4019 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    479f247 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6a017a1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    d3db2c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Configuration menu
    Copy the full SHA
    8b79cad View commit details
    Browse the repository at this point in the history
  2. Merge branch '299387-generic-screenreader-support' of github.com:Marc…

    …Sabatella/MuseScore into 299387-generic-screenreader-support
    MarcSabatella committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    a489e69 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. changes for orca

    MarcSabatella committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    5f6ad73 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Configuration menu
    Copy the full SHA
    b9a8089 View commit details
    Browse the repository at this point in the history