-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #299387: support for screenreaders other than NVDA #5592
fix #299387: support for screenreaders other than NVDA #5592
Commits on Dec 28, 2019
-
fix #298887: rename Tin Whistle to C Tin Whistle for MusicXML Instrum…
…entID wind.flutes.whistle.tin
Configuration menu - View commit details
-
Copy full SHA for 7180313 - Browse repository at this point
Copy the full SHA 7180313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 140b972 - Browse repository at this point
Copy the full SHA 140b972View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b78f34 - Browse repository at this point
Copy the full SHA 3b78f34View commit details -
Filter shortcuts by current state because single key sequence may be …
…used in various actions relative to current score state
Configuration menu - View commit details
-
Copy full SHA for 242f7ab - Browse repository at this point
Copy the full SHA 242f7abView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1b9f29 - Browse repository at this point
Copy the full SHA a1b9f29View commit details
Commits on Dec 30, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 40095b6 - Browse repository at this point
Copy the full SHA 40095b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aa3ec9 - Browse repository at this point
Copy the full SHA 3aa3ec9View commit details
Commits on Jan 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for d88c19f - Browse repository at this point
Copy the full SHA d88c19fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 917d8b5 - Browse repository at this point
Copy the full SHA 917d8b5View commit details
Commits on Jan 3, 2020
-
Specializes template routines.
Qt 5.14 introduces serialisation/deserialisation for enum classes, this results in ambiguous templates between qdatastream.h and preferences.h. we specialize everything to workaround this.
Configuration menu - View commit details
-
Copy full SHA for 09d1389 - Browse repository at this point
Copy the full SHA 09d1389View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b759bb - Browse repository at this point
Copy the full SHA 6b759bbView commit details
Commits on Jan 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f02df10 - Browse repository at this point
Copy the full SHA f02df10View commit details -
move Tremolo Bar Properties into Inspector
+ fix one last problem in #53236
Configuration menu - View commit details
-
Copy full SHA for bb71758 - Browse repository at this point
Copy the full SHA bb71758View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb72e37 - Browse repository at this point
Copy the full SHA eb72e37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30b823c - Browse repository at this point
Copy the full SHA 30b823cView commit details
Commits on Jan 5, 2020
-
fix MusicXML export part of #294815 - [Musicxml im-export] - New Tran…
…sposition and pitches messed up
Configuration menu - View commit details
-
Copy full SHA for 93a9443 - Browse repository at this point
Copy the full SHA 93a9443View commit details
Commits on Jan 6, 2020
-
support for xaphoon instrument
Eduardo Rodrigues committedJan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for 3ff35f9 - Browse repository at this point
Copy the full SHA 3ff35f9View commit details -
Eduardo Rodrigues committed
Jan 6, 2020 Configuration menu - View commit details
-
Copy full SHA for a9c80e3 - Browse repository at this point
Copy the full SHA a9c80e3View commit details -
fix #299387: support for screenreaders other than NVDA + collect_arti…
…facts Most of the MuseScore GUI uses standard Qt widgets and thus is as accessible as one can reasonably expect - especially now that the palettes have moved to QML. The main issue thing preventing other screenreaders from being viable is the scoreview. The accessibility implementation made for the screenreader several years ago works for NVDA, but a number of small details prevent other screenreaders from working. This change addresses these, allowing JAWS to work relatively normally, and Windows Narrator to also work with a manual assist (Narrator + Tab shortcut). These changes don't adversely affect NVDA, and actually improve its response somewhat, fixing some of the mysterious "split button" texts that were being read. The changes here ar small but collectivey they make a difference, oth in getting JAWS and Narrator to work better out of the box, but also in making it easier to further script JAWS to provide enhanced accessibility. I used the Microsot Accessibility Insights tool to find and debug many of these issues. - added object names and accessible text for the container objects in the main window - fixed the rect() returned by the scoreview to use global screen coordinates - gave the AccessibleScoreView a role() of StaticText rather than NoRole - allow Description as well as Value as keys to access the accessibility text() - allow Qt to determine the window() for the AccessibleScoreView - override isValid() to be sure it always returns true Tese changes allow assistive tools to better associate events with objects, and objects with windows, which is necessary in order for things to work reliably. Otherwise, there were cases where the assistive tools would be unable to find the correct object or window. Most of the changes should be completely non-controversial and harmless at worst. The change from NoRole to StaticText yielded best results after trying quite a few options. This was the only meaningful role read by Windows Narrator at all, and one of the few recognized as valid and by Accessibility Insights. There are still cases where the screenreader can get confused about the current/active object, Sometimes it can be useful to press Alt twice (transfer focus to menu bar and back). But things seem *much* better with these changes, in my testing.
Configuration menu - View commit details
-
Copy full SHA for 5b4e1e8 - Browse repository at this point
Copy the full SHA 5b4e1e8View commit details
Commits on Jan 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7118cdf - Browse repository at this point
Copy the full SHA 7118cdfView commit details -
Align the text on the left and make the size policy of spin box "Expanding".
Configuration menu - View commit details
-
Copy full SHA for 6459e33 - Browse repository at this point
Copy the full SHA 6459e33View commit details
Commits on Jan 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 47dae68 - Browse repository at this point
Copy the full SHA 47dae68View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2fc0e4 - Browse repository at this point
Copy the full SHA a2fc0e4View commit details
Commits on Jan 9, 2020
-
Merge pull request musescore#5575 from Howard-C/fingering-style
[Inspector/Regression] fix #299072: style setting for fingering in Inspector has no items
Configuration menu - View commit details
-
Copy full SHA for 50cbdcb - Browse repository at this point
Copy the full SHA 50cbdcbView commit details -
Merge pull request musescore#5583 from korli/qt5.14
fix build with Qt5.14
Configuration menu - View commit details
-
Copy full SHA for 8b9a81e - Browse repository at this point
Copy the full SHA 8b9a81eView commit details -
Merge pull request musescore#5556 from riaanvn/298887-whistle.tin.c
fix #298887: generic wind.flutes.whistle.tin is ambiguous
Configuration menu - View commit details
-
Copy full SHA for 245cd3f - Browse repository at this point
Copy the full SHA 245cd3fView commit details -
Assign a name for plugins actions
Makes running plugins from menu be visible by a telemetry. Running plugins via shortcuts still remains untracked.
Configuration menu - View commit details
-
Copy full SHA for 3fc5790 - Browse repository at this point
Copy the full SHA 3fc5790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90895e0 - Browse repository at this point
Copy the full SHA 90895e0View commit details -
Compare shortcut state through the bitwise AND, because single shortc…
…ut can work with multiple states
Configuration menu - View commit details
-
Copy full SHA for efced91 - Browse repository at this point
Copy the full SHA efced91View commit details -
Merge pull request musescore#5565 from vpereverzev/action_filter_events
Action filter events
Configuration menu - View commit details
-
Copy full SHA for 1c323d7 - Browse repository at this point
Copy the full SHA 1c323d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ecf84d - Browse repository at this point
Copy the full SHA 0ecf84dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2912558 - Browse repository at this point
Copy the full SHA 2912558View commit details -
Configuration menu - View commit details
-
Copy full SHA for 679708e - Browse repository at this point
Copy the full SHA 679708eView commit details
Commits on Jan 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3da97f3 - Browse repository at this point
Copy the full SHA 3da97f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ac7d26 - Browse repository at this point
Copy the full SHA 8ac7d26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87c14c3 - Browse repository at this point
Copy the full SHA 87c14c3View commit details
Commits on Jan 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3997e1f - Browse repository at this point
Copy the full SHA 3997e1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f362731 - Browse repository at this point
Copy the full SHA f362731View commit details
Commits on Jan 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3e40e9b - Browse repository at this point
Copy the full SHA 3e40e9bView commit details
Commits on Jan 13, 2020
-
Merge pull request musescore#5597 from Jojo-Schmitz/french_soprano_clef
Fix #299518: Add "Soprano Clef (French, 20th/18th century)"
Configuration menu - View commit details
-
Copy full SHA for 16ab5e1 - Browse repository at this point
Copy the full SHA 16ab5e1View commit details -
Merge pull request musescore#5601 from Jojo-Schmitz/harmonicas-ranges
fix #299545: Incorrect Harmonicas Ranges
Configuration menu - View commit details
-
Copy full SHA for 90c0759 - Browse repository at this point
Copy the full SHA 90c0759View commit details -
Merge pull request musescore#5595 from Howard-C/properties-inside-panel
[Inspector] Move "Properties" buttons inside inspector panels
Configuration menu - View commit details
-
Copy full SHA for de1dede - Browse repository at this point
Copy the full SHA de1dedeView commit details -
Merge pull request musescore#5593 from Howard-C/split-staff
Improve Split Staff dialogue
Configuration menu - View commit details
-
Copy full SHA for c29b06b - Browse repository at this point
Copy the full SHA c29b06bView commit details -
Merge pull request musescore#5589 from lvinken/294815-musicxml-export…
…-transpose-multi-instrument fix MusicXML export part of #294815 - [Musicxml im-export] - New Tran…
Configuration menu - View commit details
-
Copy full SHA for 7efbe85 - Browse repository at this point
Copy the full SHA 7efbe85View commit details -
Merge pull request musescore#5576 from Jojo-Schmitz/ptb
fix #44796: enable ptb import
Configuration menu - View commit details
-
Copy full SHA for 7bc323b - Browse repository at this point
Copy the full SHA 7bc323bView commit details -
Merge pull request musescore#5585 from Howard-C/tremolo-bar-properties
[Inspector] move Tremolo Bar Properties into Inspector (fix #53236)
Configuration menu - View commit details
-
Copy full SHA for 46de751 - Browse repository at this point
Copy the full SHA 46de751View commit details -
Merge pull request musescore#5591 from eduardomourar/feature/add-xaph…
…oon-instrument Support for xaphoon instrument
Configuration menu - View commit details
-
Copy full SHA for e5ec5e5 - Browse repository at this point
Copy the full SHA e5ec5e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23a3d20 - Browse repository at this point
Copy the full SHA 23a3d20View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd80864 - Browse repository at this point
Copy the full SHA bd80864View commit details
Commits on Jan 14, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a35d658 - Browse repository at this point
Copy the full SHA a35d658View commit details -
Merge pull request musescore#5603 from Jojo-Schmitz/instrtument-names
Fix new Pocket-Saxes
Configuration menu - View commit details
-
Copy full SHA for 8c9cc19 - Browse repository at this point
Copy the full SHA 8c9cc19View commit details -
fix #297719: AppImage: add more libraries
New files bundled in AppImage: - libcupsprintersupport.so - Qt printsupport plugin - libnss3.so - a fallback for Chromebook devices - findlibs - tiny C program to check system libraries
Configuration menu - View commit details
-
Copy full SHA for 21ba231 - Browse repository at this point
Copy the full SHA 21ba231View commit details -
Merge pull request musescore#5607 from shoogle/appimage-libraries
fix #297719: AppImage: add more libraries
Configuration menu - View commit details
-
Copy full SHA for 8eb74bb - Browse repository at this point
Copy the full SHA 8eb74bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39a7cbd - Browse repository at this point
Copy the full SHA 39a7cbdView commit details -
Merge pull request musescore#5572 from Howard-C/update-copyright
Update copyright
Configuration menu - View commit details
-
Copy full SHA for 385f33e - Browse repository at this point
Copy the full SHA 385f33eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f79fff7 - Browse repository at this point
Copy the full SHA f79fff7View commit details -
fix #299387: support for screenreaders other than NVDA + collect_arti…
…facts Most of the MuseScore GUI uses standard Qt widgets and thus is as accessible as one can reasonably expect - especially now that the palettes have moved to QML. The main issue thing preventing other screenreaders from being viable is the scoreview. The accessibility implementation made for the screenreader several years ago works for NVDA, but a number of small details prevent other screenreaders from working. This change addresses these, allowing JAWS to work relatively normally, and Windows Narrator to also work with a manual assist (Narrator + Tab shortcut). These changes don't adversely affect NVDA, and actually improve its response somewhat, fixing some of the mysterious "split button" texts that were being read. The changes here ar small but collectivey they make a difference, oth in getting JAWS and Narrator to work better out of the box, but also in making it easier to further script JAWS to provide enhanced accessibility. I used the Microsot Accessibility Insights tool to find and debug many of these issues. - added object names and accessible text for the container objects in the main window - fixed the rect() returned by the scoreview to use global screen coordinates - gave the AccessibleScoreView a role() of StaticText rather than NoRole - allow Description as well as Value as keys to access the accessibility text() - allow Qt to determine the window() for the AccessibleScoreView - override isValid() to be sure it always returns true Tese changes allow assistive tools to better associate events with objects, and objects with windows, which is necessary in order for things to work reliably. Otherwise, there were cases where the assistive tools would be unable to find the correct object or window. Most of the changes should be completely non-controversial and harmless at worst. The change from NoRole to StaticText yielded best results after trying quite a few options. This was the only meaningful role read by Windows Narrator at all, and one of the few recognized as valid and by Accessibility Insights. There are still cases where the screenreader can get confused about the current/active object, Sometimes it can be useful to press Alt twice (transfer focus to menu bar and back). But things seem *much* better with these changes, in my testing.
Configuration menu - View commit details
-
Copy full SHA for 60512d5 - Browse repository at this point
Copy the full SHA 60512d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfc4019 - Browse repository at this point
Copy the full SHA bfc4019View commit details -
Configuration menu - View commit details
-
Copy full SHA for 479f247 - Browse repository at this point
Copy the full SHA 479f247View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a017a1 - Browse repository at this point
Copy the full SHA 6a017a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3db2c3 - Browse repository at this point
Copy the full SHA d3db2c3View commit details
Commits on Jan 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8b79cad - Browse repository at this point
Copy the full SHA 8b79cadView commit details -
Merge branch '299387-generic-screenreader-support' of github.com:Marc…
…Sabatella/MuseScore into 299387-generic-screenreader-support
Configuration menu - View commit details
-
Copy full SHA for a489e69 - Browse repository at this point
Copy the full SHA a489e69View commit details
Commits on Jan 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 5f6ad73 - Browse repository at this point
Copy the full SHA 5f6ad73View commit details
Commits on Jan 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b9a8089 - Browse repository at this point
Copy the full SHA b9a8089View commit details