Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #313946: MusicXML import should honor "measure-style/slash" #7085

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Fix #313946: MusicXML import should honor "measure-style/slash" #7085

merged 1 commit into from
Dec 14, 2020

Conversation

infojunkie
Copy link
Contributor

Resolves: https://musescore.org/en/node/313946

This PR adds MusicXML import handling for measure-style/slash by converting incoming notes to unplayed slashes.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@infojunkie
Copy link
Contributor Author

@ericfont here's the PR to import slash notation into MuseScore.

@Jojo-Schmitz
Copy link
Contributor

@lvinken mind a review?

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Dec 14, 2020
Closed
@vpereverzev vpereverzev merged commit 7a001ad into musescore:3.x Dec 14, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 17, 2021
@igorkorsukov
ported musescore#7085 : Fix #313946: MusicXML import should honor mea…
19b2346 
…sure-style/slash
@igorkorsukov igorkorsukov mentioned this pull request Feb 17, 2021
Merged
vpereverzev pushed a commit that referenced this pull request Feb 17, 2021
@igorkorsukov @vpereverzev
ported #7085 : Fix #313946: MusicXML import should honor measure-styl…
b7c287d 
…e/slash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infojunkie @Jojo-Schmitz @vpereverzev