Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of classifiers interferes with correct protocol identification #21

Closed
Perseus opened this issue Jun 22, 2017 · 1 comment · Fixed by #22
Closed

Order of classifiers interferes with correct protocol identification #21

Perseus opened this issue Jun 22, 2017 · 1 comment · Fixed by #22

Comments

@Perseus
Copy link

Perseus commented Jun 22, 2017

I was working on a MySQL classifier and was using a pcap from here. Since the ICMP classifier comes before the MySQL classifier in the classifierList, it gets detected before MySQL because there are packets which satisfy the conditions in the classifier. It never actually gets to the MySQL classifier since it breaks off after it has "identified" a protocol.

What approach should be taken to resolve this?
@nikofil
Copy link
Collaborator

nikofil commented Jun 22, 2017

You're right, the ICMP classifier is just wrong. I'm making a PR for this.

nikofil added a commit to nikofil/go-dpi that referenced this issue Jun 22, 2017
@nikofil
classifiers: icmp classifier fix
a358e5d 
* Fixes ICMP classifier incorrectly classifying packets. (closes mushorg#21)

Signed-off-by: Nikos Filippakis <nikolaos.filippakis@cern.ch>
@nikofil nikofil mentioned this issue Jun 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

classifiers: icmp classifier fix nikofil/go-dpi
2 participants
@nikofil @Perseus