-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable tts on low battery #1202
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: properly use the listen method to disable TTS based on the battery state change
refactor: re-arrange code to ensure that we're checking for tts and battery regardless of the conditional
The button should also be disabled for tts to turn it on when the battery level is too low |
jessielw
temporarily deployed
to
android-internal
June 21, 2024 20:01
— with
GitHub Actions
Inactive
jessielw
temporarily deployed
to
android-internal
June 21, 2024 22:29
— with
GitHub Actions
Inactive
jessielw
temporarily deployed
to
android-internal
June 21, 2024 22:49
— with
GitHub Actions
Inactive
SputNikPlop
had a problem deploying
to
ios-testflight
August 20, 2024 14:39
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
August 20, 2024 14:39
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
August 20, 2024 14:42
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
August 20, 2024 14:42
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
August 20, 2024 14:47
— with
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
ios-testflight
August 20, 2024 14:57
— with
GitHub Actions
Failure
SputNikPlop
temporarily deployed
to
android-internal
August 21, 2024 06:57
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
August 21, 2024 06:57
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
August 22, 2024 05:17
— with
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
ios-testflight
August 22, 2024 05:17
— with
GitHub Actions
Inactive
As mentioned #1204 (comment) not worth increasing bundle size |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this pr is to disable the tts when the battery drops below five percent unless charging.