fix: stream preview power #1204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SputNikPlop
had a problem deploying
to
ios-testflight
GitHub Actions
Failure
SputNikPlop
had a problem deploying
to
android-internal
GitHub Actions
Failure
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
|
@kevmo314 Anything else to add to this? |
kevmo314
reviewed
Aug 20, 2024
| @@ -11,6 +11,7 @@ dependencies: | |||
| flutter: | |||
| sdk: flutter | |||
| audioplayers: ^6.0.0 | |||
| battery_plus: ^5.0.2 | |||
There was a problem hiding this comment.
Hmm I think the idea is interesting but I don't think it's worth further increasing our bundle size for this. Right now the prompt shows after a timer which wouldn't have any dependency impact.
There was a problem hiding this comment.
This though would be shared anyway if #1202 would still be implemented. Same thoughts on that one as well?
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
SputNikPlop
temporarily deployed
to
android-internal
GitHub Actions
Inactive
This was referenced Aug 21, 2024
Closed
SputNikPlop
had a problem deploying
to
android-internal
GitHub Actions
Failure
SputNikPlop
temporarily deployed
to
ios-testflight
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this is if the battery falls below 20% not charging and not in battery saving mode show the prompt that stream preview takes up lots of battery, then if the battery falls below 5% disable the stream preview if open