Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Receive data from share extensions on iOS #1215

Merged
merged 8 commits into from
Mar 3, 2024

Conversation

nkshah2
Copy link
Contributor

@nkshah2 nkshah2 commented Mar 2, 2024

This PR adds the ability for users to share selected text to the app.

Related Issues

Output

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-02.at.11.24.15.mp4

Notes

  • I had a different Cocoapods and Xcode version installed so some of the project files may have changed, should not cause issues though
  • Because some of the libraries not supporting app extensions I could not launch the Flutter app inside the extension. Instead I have the share extension launch the main app using a custom URL scheme.

ios/RealtimeChatShare/Info.plist Show resolved Hide resolved
ios/RealtimeChatShare/ShareViewController.swift Outdated Show resolved Hide resolved
ios/Runner/Info.plist Show resolved Hide resolved
Copy link
Contributor

@kevmo314 kevmo314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SputNikPlop could you do a quick test to verify it works for you too? Code looks good to me otherwise. Thanks for the contribution!

Copy link
Collaborator

@SputNikPlop SputNikPlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevmo314 works as expected! LGTM

@SputNikPlop SputNikPlop changed the base branch from build to main March 2, 2024 23:48
@SputNikPlop SputNikPlop changed the base branch from main to 1187 March 2, 2024 23:51
@SputNikPlop SputNikPlop changed the base branch from 1187 to main March 2, 2024 23:56
@SputNikPlop SputNikPlop merged commit 106d792 into muxable:main Mar 3, 2024
4 checks passed
Wolfof420Street pushed a commit to Wolfof420Street/rtchat that referenced this pull request Mar 6, 2024
* fix: build without awesome notifications

* Add share extension to copy text into chat box

* Fix build errors

* fix: styling

* fix: restore file

* fix: pubspec.lock

* fix: main.dart

---------

Co-authored-by: SputNikPlop <100245448+SputNikPlop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants