Docker - Add examples to readme of using a dockersed image of shfmt.
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a docker image of `shfmt`, so I thought I would share it. If you would like I would be happy to make this more official by putting it as part of your repo.
|
Right, @mvdan I've been thinking about adding |
|
Could you open a separate issue about that? With a proposal on how it would be implemented, in particular. |
|
cheers have now limited it to just the related projects sections :) |
mvdan
reviewed
Jun 12, 2017
| @@ -87,6 +87,7 @@ the parser and the printer. To get started, run: | |||
|
|
|||
| * [format-shell] - Atom plugin for `shfmt` | |||
| * [shell-format] - VS Code plugin for `shfmt` | |||
| * [dockerised-shfmt] - A docker image of `shfmt` **Example:** `docker run -it --rm -v "$(pwd)":/sh -w /sh jamesmstone/shfmt -l -w script.sh` | |||
There was a problem hiding this comment.
Please remove the example too - the info should be in the page the link points to. Otherwise the README would be a wall of text :)
mvdan
requested changes
Jun 16, 2017
|
I've taken the liberty of cleaning up the patch and applying it to master, keeping you as the author. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a docker image of
shfmt, so I thought I would share it. If you would like I would be happy to make this more official by putting it as part of your repo.