Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple windows #13

Merged
merged 2 commits into from
Apr 10, 2021
Merged

Conversation

jakobhellermann
Copy link
Contributor

builds on top of #12

Diff only to #12

Changes:

  • &egui_context.ctx -> egui_context.ctx()
  • new egui_context.ctx_for_window(window_id) for drawing to another window
  • egui::setup_pipeline and egui::RenderGraphConfig which needs to get run for additional windows
  • Egui{Shapes, Output, Input} -> HashMap<WindowId, Egui{Shapes, Output, Input}>

Let me know what you think 😄

@mvlabat
Copy link
Owner

mvlabat commented Apr 4, 2021

This is absolutely awesome! It was in my plans to add multiple windows support, but you took care of it much earlier than I could. :) Thanks so much for working on this!

I'll take a closer look a bit later.. And I'll probably procrastinate it for a while until we merge 0.5.

@mvlabat mvlabat mentioned this pull request Apr 10, 2021
2 tasks
@mvlabat mvlabat merged commit 9c82634 into mvlabat:main Apr 10, 2021
@mvlabat
Copy link
Owner

mvlabat commented Apr 10, 2021

Thanks a lot for your contributions!

I've just published 0.4. :)

@jakobhellermann jakobhellermann deleted the multiple-windows branch April 10, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants