Repository navigation
Replies: 1 comment
|
Thanks, @EZotoff, for asking before the PR. Yes, this direction fits as a small follow-on to #2842: put configured model/effort and the runner's observed state in the existing status region, keeping diagnostics and the editable draft intact. Restrained emphasis on runner-written lines is welcome, with the same meanings readable in plain output; keep model output and READY/EXITED/ERROR markers unchanged. Please retain streaming, layout and capture behavior, including the shared OMP path. The status line should reflect what is known rather than turn missing data or a waiting/error state into idle. Please open a narrow PR along those lines; no release date is promised. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Follow-up to #2842 (the pi-runner pane compositor, merged in 0.7.13). This is an idea before a PR, per CONTRIBUTING's "features and behaviour changes" rule — the change below alters what every pi seat's pane looks like, so I'd rather have a yes/no on the direction first.
What I am trying to do. After #2842 a Pi seat's pane is a clean single-owner surface: operator draft on its own compose line, agent stream mirrored, runner diagnostics on a pinned status line. But the pane is still monochrome and anonymous:
What stops me. Nothing structural anymore — the compositor that merged in #2842 is exactly the seam this needs. It is a behaviour change to a surface every Pi user reads, which is why this is a Discussion and not a PR.
The shape I have in mind (built and tested locally against the merged compositor, not yet proposed upstream):
NO_COLORand on a non-TTY output, so transcripts andrig capturestay plain where styling would be noise.Deliberately left out: any styling of model output and of the
READY/EXITED/[pi-runner] ERRORmarkers — adapters grep the transcript for those (pi-runtime-adapter.tsscans the last 40 pane lines), and a plain pane log stays readable. Also leaving out the grapheme-aware caret measurement discussed in #2842's review rounds — declined for now, separate concern.Questions for you: is pane styling at this layer welcome at all, or is the pane meant to stay a dumb terminal? If welcome, is the status line the right home for seat identity, or would you rather that lived elsewhere (e.g. the TUI seat card) and the pane stay content-only?
All reactions