Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.16-dev #1147

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Version 1.16-dev #1147

merged 9 commits into from
Oct 24, 2023

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Oct 22, 2023

In this PR we update the documentation following #1140

Closes #1139

@LecrisUT @mahendrapaipuri let me know if you see anything else to mention in the documentation.

@@ -1,6 +1,14 @@
Jupytext ChangeLog
==================

1.16.0-dev (2023-10-??)
Copy link
Contributor

@LecrisUT LecrisUT Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to top-level Changelog.md and use include to link to it? Here's an example of using include.

The idea is to have it in keep-a-changelog form so it is easier to incrementally add changelog

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great! Actually I could use that for the README.md too (index.md is almost a verbatim copy of ../README.md)

docs/index.md Outdated
@@ -1,4 +1,4 @@
![CI](https://github.com/mwouts/jupytext/actions/workflows/continuous-integration.yml/badge.svg?branch=main)
![CI](https://github.com/mwouts/jupytext/actions/workflows/ci.yml/badge.svg?branch=main)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this one reports as passed. If not we can look at how to report only the las job in the CI

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it does! CI

Base automatically changed from jupyterlab-jupytext-1.3.10_and_1.4.0 to main October 22, 2023 21:08
Copy link
Contributor

@mahendrapaipuri mahendrapaipuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @mwouts for working on doc changes. LGTM, I left couple of minor comments.

I see you removed references to Notebook in the docs as we removed "legacy" nbextension. But with Notebook >=7, we can use the extension exactly the same way as we do with JupyterLab 4, i.e., from command palette. Maybe adding a line saying that somewhere in the docs can be useful?

I see the value of feature proposed in #1095. I will try to work on it if someone is not already on it. Let me know.


**Changed**
- Jupytext is now configured with `pyproject.toml` and built with `hatch`. The layout has been reorganised to follow `src-layout` ([#1140](https://github.com/mwouts/jupytext/issues/1140)). This outstanding update was contributed by [Mahendra Paipuri](https://github.com/mahendrapaipuri).
- The extension for Jupyter Notebook (the Jupytext Menu) has been removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specifying Notebook version is more clear.

Suggested change
- The extension for Jupyter Notebook (the Jupytext Menu) has been removed.
- The legacy extension for Jupyter Notebook <=6 (the Jupytext Menu) has been removed.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure! I've added this change to CHANGELOG.md (the file has been moved at the root now)

docs/install.md Outdated Show resolved Hide resolved
mwouts and others added 3 commits October 24, 2023 17:30
Co-authored-by: Mahendra Paipuri <44365948+mahendrapaipuri@users.noreply.github.com>
@mwouts
Copy link
Owner Author

mwouts commented Oct 24, 2023

I see you removed references to Notebook in the docs as we removed "legacy" nbextension. But with Notebook >=7, we can use the extension exactly the same way as we do with JupyterLab 4, i.e., from command palette. Maybe adding a line saying that somewhere in the docs can be useful?

Yes that's a good point! I'll add this

I see the value of feature proposed in #1095. I will try to work on it if someone is not already on it. Let me know.

Yes the option to create text notebooks directly would be very useful indeed! The idea was suggested by @parmentelat so maybe we can first check with him first if he has anything he wants to share.

Also do you think the command palette is the way to go, or would you recommend to also make these commands available in a menu as for the legacy notebook extension?

@@ -1,6 +1,14 @@
Jupytext ChangeLog
==================

1.16.0-dev (2023-10-??)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using a <!-- SPHINX-START --> tag to change the header. This is particularly useful for the README.md to filter out the badges. Another cool feature is to use markdown reference-style links to correct the links. It should work with myst-parser

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting. In index.md we currently have the badges so I was thinking of keeping them, but sure I will filter out the logo. Yes I've seen about the links and it's very useful to convert the links from the README.md where there point to docs, to index.md where they are local.

@mwouts mwouts merged commit 710be91 into main Oct 24, 2023
18 of 20 checks passed
@mwouts mwouts deleted the version_1.16-dev branch October 24, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Changelog to RTD docs
3 participants