Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Scapegoat sensor not respecting module path for multi module projects. #96

Merged
merged 2 commits into from Aug 11, 2018

Conversation

@mwz
Copy link
Owner

mwz commented Aug 11, 2018

This PR fixes the Scapegoat sensor issue with multi-module projects where the report from the root module was used for each submodule. The fix was to resolve each report path relative to the working directory including the module directory when the sensor gets executed.

This fixes #92.

Hi @BalmungSan 馃憢, would you be able to review this PR?

@mwz mwz added this to In progress in sonar-scala via automation Aug 11, 2018
@@ -363,6 +379,62 @@ class ScapegoatSensorSpec
// validate the sensor behavior
sensorContext.allIssues shouldBe empty
}

it should "not report module issues" in {

This comment has been minimized.

Copy link
@BalmungSan

BalmungSan Aug 11, 2018

Contributor

I think that 'not' is out of place.

This comment has been minimized.

Copy link
@mwz

mwz Aug 11, 2018

Author Owner

thanks for spotting this - fixed in 61a613a

@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Aug 11, 2018

Hi @mwz, Thanks a lot for fixing this, I have been incredibly busy, I'm sorry about that.

Everything looks fine to me (except for that test name).

Just one thing, maybe we should bump some dependencies in this PR too, like sbt to 1.2.1, sbt-assembly to 0.14.7, etc...

馃憤

@mwz

This comment has been minimized.

Copy link
Owner Author

mwz commented Aug 11, 2018

Thanks for the review @BalmungSan. Since this is a hotfix, I'll just release it with the current versions and bump up dependencies and plugins in a separate PR.

@BalmungSan

This comment has been minimized.

Copy link
Contributor

BalmungSan commented Aug 11, 2018

Ok, go ahead.

@mwz mwz merged commit 797ce88 into master Aug 11, 2018
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
sonar-scala automation moved this from In progress to Done Aug 11, 2018
@mwz mwz deleted the scapegoat-multi-module-fix branch Aug 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
sonar-scala
  
Done
2 participants
You can鈥檛 perform that action at this time.