Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merged refactors (#52) #226

Merged
merged 19 commits into from
Apr 3, 2023

Conversation

myConsciousness
Copy link
Owner

@myConsciousness myConsciousness commented Apr 1, 2023

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness self-assigned this Apr 1, 2023
@myConsciousness myConsciousness linked an issue Apr 1, 2023 that may be closed by this pull request
@github-actions github-actions bot added atproto A label indicating the package `atproto`. atproto/lexicon/repositories A label indicating the service related to `com.atproto.repo.*`. atproto/lexicon/identities A label indicating the service related to `com.atproto.identity.*`. atproto/lexicon/moderation A label indicating the service related to `com.atproto.moderation.*`. bluesky A label indicating the package `bluesky`. bluesky_cli A label indicating the package `bluesky_cli`. bsky/lexicon/actors A label indicating the service related to `app.bsky.actor.*`. bsky/lexicon/feeds A label indicating the service related to `app.bsky.feed.*`. bsky/lexicon/graphs A label indicating the service related to `app.bsky.graph.*`. bsky/lexicon/notifications A label indicating the service related to `app.bsky.notification.*`. bsky/lexicon/unspecced A label indicating the service related to `app.bsky.unspecced.*`. test labels Apr 1, 2023
@github-actions github-actions bot added bluesky_cards A label indicating the package `bluesky_cards`. documentation Improvements or additions to documentation atproto/lexicon/servers A label indicating the service related to `com.atproto.server.*`. labels Apr 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2023

Codecov Report

Merging #226 (80b4fff) into main (a5dc8ee) will decrease coverage by 1.42%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
- Coverage   80.48%   79.07%   -1.42%     
==========================================
  Files          83       83              
  Lines         656      650       -6     
==========================================
- Hits          528      514      -14     
- Misses        128      136       +8     
Impacted Files Coverage Δ
packages/atproto/lib/src/atproto.dart 0.00% <0.00%> (ø)
packages/atproto/lib/src/atproto_service.dart 0.00% <0.00%> (ø)
...atproto/lib/src/identities/identities_service.dart 100.00% <ø> (ø)
...ackages/bluesky/lib/src/actors/actors_service.dart 100.00% <ø> (ø)
packages/bluesky/lib/src/bluesky.dart 0.00% <0.00%> (ø)
packages/bluesky/lib/src/bluesky_base_service.dart 100.00% <ø> (ø)
packages/bluesky/lib/src/bluesky_service.dart 0.00% <0.00%> (ø)
...ackages/bluesky/lib/src/graphs/graphs_service.dart 100.00% <ø> (ø)
...y/lib/src/notifications/notifications_service.dart 100.00% <ø> (ø)
...sky/lib/src/repositories/repositories_service.dart 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness
Copy link
Owner Author

Need to check if identifier is required to create a session.

@myConsciousness myConsciousness merged commit 7fbbbff into main Apr 3, 2023
@myConsciousness myConsciousness deleted the 52-large-refactoring-in-official branch April 3, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atproto/lexicon/identities A label indicating the service related to `com.atproto.identity.*`. atproto/lexicon/moderation A label indicating the service related to `com.atproto.moderation.*`. atproto/lexicon/repositories A label indicating the service related to `com.atproto.repo.*`. atproto/lexicon/servers A label indicating the service related to `com.atproto.server.*`. atproto A label indicating the package `atproto`. bluesky_cards A label indicating the package `bluesky_cards`. bluesky_cli A label indicating the package `bluesky_cli`. bluesky A label indicating the package `bluesky`. bsky/lexicon/actors A label indicating the service related to `app.bsky.actor.*`. bsky/lexicon/feeds A label indicating the service related to `app.bsky.feed.*`. bsky/lexicon/graphs A label indicating the service related to `app.bsky.graph.*`. bsky/lexicon/notifications A label indicating the service related to `app.bsky.notification.*`. bsky/lexicon/unspecced A label indicating the service related to `app.bsky.unspecced.*`. documentation Improvements or additions to documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large refactoring in official
2 participants