Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add langs field #642

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

Uinelj
Copy link
Contributor

@Uinelj Uinelj commented Aug 6, 2023

1. Description

Adds the lang field on posts.

I haven't found any unit tests related to this, but do tell me if I need to add some somewhere :)

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

Fixes #640

@netlify
Copy link

netlify bot commented Aug 6, 2023

Deploy Preview for jade-haupia-45bdc2 canceled.

Name Link
🔨 Latest commit b64eff8
🔍 Latest deploy log https://app.netlify.com/sites/jade-haupia-45bdc2/deploys/64cf874494c86b000818da07

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :)

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023

Codecov Report

Merging #642 (b64eff8) into main (40e16a4) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #642      +/-   ##
==========================================
- Coverage   86.54%   86.46%   -0.09%     
==========================================
  Files         223      223              
  Lines        2475     2475              
==========================================
- Hits         2142     2140       -2     
- Misses        333      335       +2     
Files Changed Coverage Δ
packages/bluesky/lib/src/entities/post_record.dart 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness myConsciousness self-requested a review August 7, 2023 05:33
@myConsciousness
Copy link
Owner

Hi @Uinelj !

There is a following unit test, but this is to ensure the minimum necessary behavior, so don't worry about it, at least not yet. I have already confirmed the correctness of your implementation. But well I plan to add more accurate tests in the future.

Thanks for your contribution, it looks good to me :)

@myConsciousness myConsciousness merged commit a165867 into myConsciousness:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Suggestion: Support langs in PostRecord
3 participants