Skip to content

Conversation

ready-research
Copy link
Contributor

Fixes #803

@jeffgbutler
Copy link
Member

One of the lines in this PR breaks the Eclipse functionality. I've just added some tests that show the problem. Once you rebase your branch, you can run the Eclipse plugin tests this way:

  1. Open a terminal in the .../eclipse/org.mybatis.generator.eclipse.parent directory
  2. Run the command ./mvnw -Prelease-composite clean integration-test

@coveralls
Copy link

coveralls commented Jan 18, 2022

Coverage Status

Coverage remained the same at 88.164% when pulling a0468b8 on ready-research:ready-research-XXE into a1221b1 on mybatis:master.

@jeffgbutler jeffgbutler merged commit 7abca13 into mybatis:master Jan 18, 2022
@jeffgbutler
Copy link
Member

Thanks for your contribution!

@ready-research
Copy link
Contributor Author

@jeffgbutler Can you please validate the same in huntr by using Mark as valid and also Confirm the fix. Thanks.
https://huntr.dev/bounties/acd74536-dea0-4507-8c2c-1df3e21a948a/

@jeffgbutler
Copy link
Member

@ready-research I don't use huntr, but perhaps you can link this PR to whatever entry is in that system.

@kazuki43zoo kazuki43zoo added this to the 1.4.1 milestone Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Who to contact for security issues
4 participants