Add KotlinType companion object and KotlinProperty const #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job! Thank you for writing tests. |
|
My pleasure. I've been using the framework since Abator, so it's about time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Kotlin DSL does not yet allow for creating companion objects and/or const val's. Having this ability is useful for a number of reasons. One specific reason is to generate constants for column names. This allows custom result mappings to be a bit more typesafe, reducing the scope of typing errors further.
Example of a generated DynamicSqlSupport class and a custom mapper with typesafe columns:
mybatis-generator-pull-request.txt