Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/
package org.apache.ibatis.reflection.property;

import java.util.Locale;
import java.beans.Introspector;

import org.apache.ibatis.reflection.ReflectionException;

Expand All @@ -37,11 +37,7 @@ public static String methodToProperty(String name) {
throw new ReflectionException("Error parsing property name '" + name + "'. Didn't start with 'is', 'get' or 'set'.");
}

if (name.length() == 1 || (name.length() > 1 && !Character.isUpperCase(name.charAt(1)))) {
name = name.substring(0, 1).toLowerCase(Locale.ENGLISH) + name.substring(1);
}

return name;
return Introspector.decapitalize(name);
}

public static boolean isProperty(String name) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package org.apache.ibatis.reflection.property;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.*;

class PropertyNamerTest {

@Test
void methodToProperty() {
assertEquals("ok", PropertyNamer.methodToProperty("isOk"));
assertEquals("OK", PropertyNamer.methodToProperty("isOK"));

assertEquals("name", PropertyNamer.methodToProperty("getName"));
assertEquals("XName", PropertyNamer.methodToProperty("getXName"));
assertEquals("xName", PropertyNamer.methodToProperty("getxName"));

assertEquals("name", PropertyNamer.methodToProperty("setName"));
assertEquals("XName", PropertyNamer.methodToProperty("setXName"));
assertEquals("xName", PropertyNamer.methodToProperty("setxName"));
}
}