Change the cast targets #2648
Closed
Change the cast targets #2648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IrvingOS If you can, please rebase this instead of merging into it so its cleaner at the onset. The approach seems fine but need others to comment from the team. |
|
Yeah. I'll clean up the commits and reissue the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the cast target to WeakEntry in WeakCache.class.
Change the cast target to SoftEntry in SoftCache.class.
Because I don't think it's necessary to convert delegate.get(key) to WeakReference or SoftReference and then suppress the warning with @SuppressWarnings("unchecked").
If my idea is wrong, please point it out.
Thanks!