Kotlin Support Updates #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jeffgbutler
commented
Aug 29, 2019
jeffgbutler
commented
- Rework the utility methods to be more consistent
- Add Java methods to accept a collection of select columns rather than just an array (this avoids a messy use of the Kotlin spread operator in some cases)
- Update the documentation to show the new pattern
- Format the code to the Kotlin style guide
Arrays are always turned into lists eventually, so we can support that at the edges.
- Make consistent functions for building providers - Make consistent functions for executing mappers - Format code according to Kotlin style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.