Add Ability to Modify SQL After Generation #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow post generation changes to generated SQL
|
Thank you for this PR, if it does what i think, it's very interessing. Can you decorate also the selected fields ? (It is necessary to implement proprietary functions of each SQL server for example) |
|
Yes, it's possible but I think it would be better to implement those functions so the SQL is generated correctly to start. Otherwise you will have to parse the generated SQL which can be difficult. The main motivation for this enhancement was to support paging queries - which usually just involves appending something to the end of the generated SQL. But you do have the option now to handle it any way that seems best to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all the provider classes into interfaces to that another class could act as a decorator and make changes before the SQL is executed.
The test shows how to create a paging query using a decorator.