Support interceptor sorting during auto config SqlSessionFactory #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carter-ya
changed the title
|
@carter-ya In my understand, auto-wired interceptor already was sorted using spring ordered feature( |
kazuki43zoo
added a commit
to kazuki43zoo/spring-boot-starter
that referenced
this pull request
Dec 31, 2021
kazuki43zoo
added a commit
that referenced
this pull request
Dec 31, 2021
…eptors Add test for ordering interceptor
|
Thank you for your reply! I have tested the injected behavior and it is indeed sorted automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When autowire the interceptors, not respect the Spring sorting style (using
@Orderor implements theOrderedinterface). Some scenarios will depend on the execution order of the Interceptor, such as expecting to obtain the rewritten SQL and parameters after thePaginationInterceptoris executed.