2nd cache doesn't work properly

[Alwayswithme]

Description

I am using mybatis-spring-1.2.2, mybatis-3.2.8, spring-4.1.4.1.1.RELEASE
I have a spring bean call deviceMapper like this.

public interface DeviceMapper {
    @Select("SELECT * FROM Device")
    List<Device> all1();

    List<Device> all2();
}

<?xml version="1.0" encoding="UTF-8" ?>
<!DOCTYPE mapper
        PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN"
        "http://mybatis.org/dtd/mybatis-3-mapper.dtd">

<mapper namespace="com.springapp.mvc.mapper.DeviceMapper">
    <cache readOnly="false"/>

    <select id="all2" resultType="device">
      SELECT * FROM Device
    </select>

</mapper>

And then I inject it and use it in a test method like this, and the XML query work well.

public class DeviceMapperTest {
    @Autowired
    private DeviceMapper deviceMapper;

    void test() {
        deviceMapper.all1();    // JDBC connection open
        deviceMapper.all1();    // connection open again, no cache hit

        deviceMapper.all2();    // JDBC connection open
        deviceMapper.all2();    // cache hit
    }
}

Log Output

DEBUG - Creating a new SqlSession
DEBUG - SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@3312a3e2] was not registered for synchronization because synchronization is not active
DEBUG - Fetching JDBC Connection from DataSource
DEBUG - JDBC Connection [ProxyConnection[PooledConnection[com.mysql.jdbc.JDBC4Connection@de62b5b]]] will not be managed by Spring
DEBUG - ==> Preparing: SELECT * FROM Device
DEBUG - ==> Parameters:
DEBUG - <== Total: 3
DEBUG - Closing non transactional SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@3312a3e2]
DEBUG - Returning JDBC Connection to DataSource
DEBUG - Creating a new SqlSession
DEBUG - SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@19256710] was not registered for synchronization because synchronization is not active
DEBUG - Fetching JDBC Connection from DataSource
DEBUG - JDBC Connection [ProxyConnection[PooledConnection[com.mysql.jdbc.JDBC4Connection@de62b5b]]] will not be managed by Spring
DEBUG - ==> Preparing: SELECT * FROM Device
DEBUG - ==> Parameters:
DEBUG - <== Total: 3
DEBUG - Closing non transactional SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@19256710]
DEBUG - Returning JDBC Connection to DataSource
DEBUG - Creating a new SqlSession
DEBUG - SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@920693f] was not registered for synchronization because synchronization is not active
DEBUG - Cache Hit Ratio [com.springapp.mvc.mapper.DeviceMapper]: 0.0
DEBUG - Fetching JDBC Connection from DataSource
DEBUG - JDBC Connection [ProxyConnection[PooledConnection[com.mysql.jdbc.JDBC4Connection@de62b5b]]] will not be managed by Spring
DEBUG - ==> Preparing: SELECT * FROM Device
DEBUG - ==> Parameters:
DEBUG - <== Total: 3
DEBUG - Closing non transactional SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@920693f]
DEBUG - Returning JDBC Connection to DataSource
DEBUG - Creating a new SqlSession
DEBUG - SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@592ba177] was not registered for synchronization because synchronization is not active
DEBUG - Cache Hit Ratio [com.springapp.mvc.mapper.DeviceMapper]: 0.5
DEBUG - Closing non transactional SqlSession [org.apache.ibatis.session.defaults.DefaultSqlSession@592ba177]

If I using a @CacheNamespace in mapper interface instead of <cache /> in mapper XML, it became the annotation query work well.

    void test() {
        deviceMapper.all1();    // JDBC connection open
        deviceMapper.all1();    // cache hit

        deviceMapper.all2();    // JDBC connection open
        deviceMapper.all2();    // connection open again, no cache hit
    }

If my usage is incorrect and misunderstand the cache usage, please let me know.

[xueyumusic]

The xml and annotation mapper use different MapperBuilderAssistant which has independent currentCache. The select in xml is bulit by XMLMapperBuilder which has its own MapperBuilderAssistant object. The method in mapper interface which has annotation is built by MapperAnnotationBuilder which has another MapperBuilderAssistant

[harawata]

@xueyumusic 's comment seems to be correct.
Let me know if you think otherwise.
And thank you for the detailed report!

[kid1412621]

so,how to fix the problem?the same question still exists

[harawata]

@kid1412621 ,

What question?
This was a bug report and @xueyumusic explained that it was not a bug.

If you have a question, please post it to the mailing list with SSCCE/MCVE.
We use GitHub Issues only to track bugs and feature requests.
Thank you!

[harawata]

@kid1412621 ,
To use cache in both Java and XML mappers, use <cache /> in the XML mapper and add @CacheNamespeceRef(YourMapper.class) to the Java mapper.
Is this the answer you are looking for?

[kid1412621]

@harawata Thank you for reply.
I mean when I use @Cachenamespace annotation to specify the Cache class which is MybatisRedisCache instead of using , the SQL query doing just fine, but cannot put Object into or get Object from the cahche.
I think using XML files is pretty tedious,I just want to use Java annotation in my code.
I will send more detail about my problem to the mailing list if it is necessary.

[harawata]

@kid1412621 ,
I'm not sure what your problem is, but if you are not using XML mapper, it is a different issue than this one.

Please send the details to the mailing list.
Linking to an executable project or test case is the best way to get useful answers.
Here are some project templates.

[wqbill]

@harawata
Sorry to bother you.I tried

use <cache /> in the XML mapper and add @CacheNamespeceRef(YourMapper.class) to the Java mapper

still do not work out.
nested exception is org.apache.ibatis.builder.IncompleteElementException: No cache for namespace 'com.example.demo.config.MybatisCache' could be found.
If use @CacheNamespace instead then
nested exception is java.lang.IllegalArgumentException: Caches collection already contains value for com.example.demo.dao.mapper.TestMapper

[harawata]

@wqbill ,
No problem at all. :)
The hardest part is to reproduce the problem on my end, so please upload the project you used to test to your GitHub repo. Then I will look into it.