Use modern phpunit #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
reviewed
Jun 27, 2017
| - hhvm | ||
|
|
||
| matrix: | ||
| allow_failures: | ||
| - php: hhvm |
There was a problem hiding this comment.
That change means that HHVM is no longer supported, is there a reason for that?
There was a problem hiding this comment.
Yes, it fails ;)
And lot of projects slowly drop support for it (including Symfony which is in the dep tree)
| @@ -40,14 +40,11 @@ public function testGetKey() | |||
|
|
|||
| /** | |||
| * @dataProvider invalidValueProvider | |||
| * @expectedException UnexpectedValueException | |||
| * @expectedExceptionMessage is not part of the enum MyCLabs\Tests\Enum\EnumFixture | |||
There was a problem hiding this comment.
The test is not the same, the first part of the message is not tested anymore
There was a problem hiding this comment.
yes, but didn't find any other way
|
Notice, this PR is mostly required to run test suite with modern PHP version, as various fix for 7.1, 7.2.. are only available in latest PHPUnit So using old PHPUnit 4 with recent PHP versions will probably raise some failures. |
|
Thank you for the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow 4.8.35, 5.7, 6.0 which all have the forward compatibility layer
So
7.2 enabled in travis.