Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete option for connecting email #180

Merged
merged 3 commits into from
Dec 8, 2021
Merged

fix: delete option for connecting email #180

merged 3 commits into from
Dec 8, 2021

Conversation

Mark-Ernst
Copy link

No description provided.

@EdieLemoine EdieLemoine changed the title My 30537 remove email setting fix: delete option for connecting phone number Dec 3, 2021
joerivanveen
joerivanveen requested changes Dec 6, 2021
View reviewed changes
Copy link

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In dit hele stuk raak je best veel aan qua formatting, maak dan svp ook gelijk enkele aanhalingstekens in de regels die je aanraakt.

includes/admin/class-wcmpbe-export.php Show resolved Hide resolved
@Mark-Ernst Mark-Ernst changed the title fix: delete option for connecting phone number fix: delete option for connecting email Dec 7, 2021
joerivanveen
joerivanveen approved these changes Dec 7, 2021
View reviewed changes
Copy link

@joerivanveen joerivanveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Het is overzichtelijker als je die hele formatting van die ene functie achterwege laat, zodat dat niet als wijziging gepresenteerd wordt, maar zoals besproken geen dealbreaker voor mij

@Mark-Ernst Mark-Ernst merged commit caa9a93 into develop Dec 8, 2021
@Mark-Ernst Mark-Ernst deleted the MY-30537-remove-email-setting branch December 8, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdieLemoine EdieLemoine EdieLemoine approved these changes

@joerivanveen joerivanveen joerivanveen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mark-Ernst @EdieLemoine @joerivanveen