Skip to content

Conversation

davidedmundson
Copy link

This fixes child nodes working under home-assistant

This fixes child nodes working under home-assistant
@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad
Copy link
Member

Could this be fixed in HomeAssistant instead? A bit worried how other controllers would react if we introduced this message.

@davidedmundson
Copy link
Author

Other controllers will need it too.

Gateways having child sensors is new.
Its mysensors "breaking" behavior by now having sensors without a presented sensor.

This patch brings the serial API to be the same as previous releases from the POV of the controller.

@henrikekblad
Copy link
Member

Hmm, true. It should probably be defined as a repeater anyhow. Could you update this?

@henrikekblad henrikekblad reopened this Apr 27, 2016
@mysensors-jenkins
Copy link

Core tests successful.
A member of the MySensors core team can ask me to verify this pull request more extensively by telling me "jenkins, build examples please".
But remember that I will only listen if you name me with a capital 'J'.

@henrikekblad
Copy link
Member

henrikekblad commented Apr 27, 2016

When thinking a bit more it should probably be:

#if defined(MY_REPEATER_FEATURE)
   present(NODE_SENSOR_ID, S_ARDUINO_REPEATER);
#else
   present(NODE_SENSOR_ID, S_ARDUINO_NODE);
#endif

@henrikekblad
Copy link
Member

Fixed in #426

tbowmo pushed a commit to tbowmo/MySensors that referenced this pull request Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants