Skip to content

Fix MCP9808 + new features #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Fix MCP9808 + new features #484

merged 1 commit into from
Jun 6, 2019

Conversation

pilotak
Copy link

@pilotak pilotak commented Jun 3, 2019

There was no begin() and wake() in code so it didn't work. I also added new features to extend the functionality

@pilotak
Copy link
Author

pilotak commented Jun 3, 2019

it's failing due to SensorAM2320 so not related to this PR

@user2684
Copy link
Contributor

user2684 commented Jun 5, 2019

Thanks for the fix! Yes, there is an issue with the library SensorAM2320 is depending from (see #482) so the workaround is to comment it out for now. Let me first merge #482 first so I can ask you to copy in the same file and have a clean compilation. Thanks!

@user2684 user2684 merged commit a266029 into mysensors:development Jun 6, 2019
@user2684
Copy link
Contributor

user2684 commented Jun 6, 2019

Merged, no need to change any file. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants