2646 pre and post 2019 election attendance #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismytton
requested changes
Jul 5, 2019
There was a problem hiding this comment.
Thanks for this @xybrnet! Looks like there's something not quite right though, I'm seeing "2019 - post elections" twice in the dropdown on the attendance page:
I'm guessing one of these should be pre-elections? 🙂
xybrnet
force-pushed
the
2646-pre-and-post-2019-election-attendance
branch
from
338d9e1
to
7a39485
Compare
|
Thank you for catching that @chrismytton. |
Thanks! Will take another look at this today. |
chrismytton
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
Looks good to me, thanks again @xybrnet! 👍
Will get this merged and deployed this afternoon.
|
@xybrnet This has now been deployed to the live site: https://www.pa.org.za/mp-attendance/ |
|
Thank you for pushing this out @chrismytton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit ugly, but we need to differentiate 2019 attendance between pre- and post-election records, the dividing date being the opening of the 6th parliament, 1 July 2019.
The PMG API returns annual data from 1 Jan - 31 Dec, so if the user has selected to view records for 2019 (which is the default view for the page until there we receive records for 2020), we divide the results into those before and after 1 July 2019 return the selected records.