Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MySqlConnector/MySqlBulkCopy.cs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ private async ValueTask<MySqlBulkCopyResult> WriteToServerAsync(IOBehavior ioBeh
using (var reader = await cmd.ExecuteReaderAsync(CommandBehavior.SchemaOnly, ioBehavior, cancellationToken).ConfigureAwait(false))
{
var schema = reader.GetColumnSchema();
for (var i = 0; i < Math.Min(m_valuesEnumerator!.FieldCount, schema.Count); i++)
for (var i = 0; i < schema.Count; i++)
{
var destinationColumn = reader.GetName(i);
if (schema[i].DataTypeName == "BIT")
Expand Down Expand Up @@ -295,7 +295,7 @@ private async ValueTask<MySqlBulkCopyResult> WriteToServerAsync(IOBehavior ioBeh
}

// set columns and expressions from the column mappings
for (var i = 0; i < m_valuesEnumerator.FieldCount; i++)
for (var i = 0; i < m_valuesEnumerator!.FieldCount; i++)
{
var columnMapping = columnMappings.FirstOrDefault(x => x.SourceOrdinal == i);
if (columnMapping is null)
Expand Down
39 changes: 39 additions & 0 deletions tests/IntegrationTests/BulkLoaderAsync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -635,6 +635,45 @@ public async Task BulkCopyNullDataReader()
var bulkCopy = new MySqlBulkCopy(connection);
await Assert.ThrowsAsync<ArgumentNullException>(async () => await bulkCopy.WriteToServerAsync(default(DbDataReader)));
}

[Fact]
public async Task BulkCopyGeometryAsync()
{
var dataTable = new DataTable()
{
Columns =
{
new DataColumn("geo_data", typeof(MySqlGeometry)),
},
Rows =
{
new object[] { MySqlGeometry.FromWkb(0, [1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 240, 63, 0, 0, 0, 0, 0, 0, 240, 63]) },
},
};

using var connection = new MySqlConnection(GetLocalConnectionString());
await connection.OpenAsync();
using (var cmd = new MySqlCommand(@"drop table if exists bulk_load_data_table;
create table bulk_load_data_table(id BIGINT UNIQUE NOT NULL AUTO_INCREMENT, geo_data GEOMETRY NOT NULL);", connection))
{
await cmd.ExecuteNonQueryAsync();
}

var bc = new MySqlBulkCopy(connection)
{
DestinationTableName = "bulk_load_data_table",
ColumnMappings =
{
new()
{
SourceOrdinal = 0,
DestinationColumn = "geo_data",
},
},
};

await bc.WriteToServerAsync(dataTable);
}
#endif

private static string GetConnectionString() => BulkLoaderSync.GetConnectionString();
Expand Down
39 changes: 39 additions & 0 deletions tests/IntegrationTests/BulkLoaderSync.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1284,6 +1284,45 @@ public void BulkCopyDataTableConflictOption(MySqlBulkLoaderConflictOption confli
using (var cmd = new MySqlCommand("select b from bulk_load_data_table;", connection))
Assert.Equal(expected, cmd.ExecuteScalar());
}

[Fact]
public void BulkCopyGeometry()
{
var dataTable = new DataTable()
{
Columns =
{
new DataColumn("geo_data", typeof(MySqlGeometry)),
},
Rows =
{
new object[] { MySqlGeometry.FromWkb(0, [1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 240, 63, 0, 0, 0, 0, 0, 0, 240, 63]) },
},
};

using var connection = new MySqlConnection(GetLocalConnectionString());
connection.Open();
using (var cmd = new MySqlCommand(@"drop table if exists bulk_load_data_table;
create table bulk_load_data_table(id BIGINT UNIQUE NOT NULL AUTO_INCREMENT, geo_data GEOMETRY NOT NULL);", connection))
{
cmd.ExecuteNonQuery();
}

var bc = new MySqlBulkCopy(connection)
{
DestinationTableName = "bulk_load_data_table",
ColumnMappings =
{
new()
{
SourceOrdinal = 0,
DestinationColumn = "geo_data",
},
},
};

bc.WriteToServer(dataTable);
}
#endif

internal static string GetConnectionString() => AppConfig.ConnectionString;
Expand Down
2 changes: 1 addition & 1 deletion tests/IntegrationTests/IntegrationTests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<ServerGarbageCollection>true</ServerGarbageCollection>
<ConcurrentGarbageCollection>true</ConcurrentGarbageCollection>
<ThreadPoolMinThreads>64</ThreadPoolMinThreads>
<LangVersion>11.0</LangVersion>
<LangVersion>12.0</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<NoWarn>$(NoWarn);SA0001;SA1021;SA1133;xUnit1030</NoWarn>
</PropertyGroup>
Expand Down
Loading