Make MySQLCursor.callproc & stored_results more consistent #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Choose matching (buffered) cursor for populating stored_results (e.g. so get dict result if using dict cursor) - Always return simple sequence of arguments from callproc, even if cursor if of type dict or namedtuple
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MySQLCursor.callproc()documentation states:and
Currently the following limitations apply:
callproc()is not necessarily a sequence, e.g. if using a dict or namedtuple cursor. Since procedure/function arguments are always supplied as a sequence it probably makes sense for a sequence (tuple) to always be returned.MySQLCursorBufferedinstance will be used forstored_results(), maybe it would make more sense to use the same cursor type (buffered) as chosen by the user, so they can processstored_results()output in a similar fashion to output from other queries.This patch tries do addresses the above two issues.