Implement unread_result setter in CMySQLConnection #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CMySQLConnection` inherits from `MySQLConnectionAbstract`, which implements both the `unread_result` property _and_ the `unread_result` setter. In python, if you inherit a property and a setter from a base class (in this case, `MySQLConnectionAbstract`), and then override the property, this _also overrides the setter_. So then when other code tries to use the setter (e.g. [here](https://github.com/mysql/mysql-connector-python/blob/master/lib/mysql/connector/cursor.py#L835)), it fails.
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
+1 on getting this merged in. Ran into the same issue, and resolved with this PR. 👍 |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
|
Sorry, couldn't be bothered to go through the process just to merge a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMySQLConnectioninherits fromMySQLConnectionAbstract, which implements both theunread_resultproperty and theunread_resultsetter.In python, if you inherit a property and a setter from a base class (in this case,
MySQLConnectionAbstract), and then override the property, this also overrides the setter. So then when other code tries to use the setter (e.g. here), it fails.