Fix binary flag test in cext. #51
Conversation
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html |
|
Hi! I have submitted the OCA. You can find my name (Frane Saric) in the published list. |
fsaric
force-pushed
the
mysql_binary_flag_fix
branch
from
b09fdde to
9cac978
Compare
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
|
FYI, checking |
MySQL Connector 8.0.16 with cext tries to decode binary values as unicode strings because it fails to detect when a BINARY_FLAG is set on a MySQL value.
The old test
!((flags != NULL) & flags & BINARY_FLAG)is always 1 (i.e. it assumes the field is not binary).This fix also allows MySQL connector to work seamlessly with SQLAlchemy (without any unicode/binary conversion issues).