Fix BUG96280 #55
Fix BUG96280 #55
Conversation
lib/mysql/connector/protocol.py
Outdated
| @@ -475,9 +475,18 @@ def _parse_binary_values(self, fields, packet, charset='utf-8'): | |||
| elif field[1] == FieldType.TIME: | |||
| (packet, value) = self._parse_binary_time(packet, field) | |||
| values.append(value) | |||
| elif field[1] in (FieldType.BLOB, FieldType.TINY_BLOB, | |||
| FieldType.MEDIUM_BLOB, FieldType.LONG_BLOB): | |||
There was a problem hiding this comment.
This is wrong fix. Field type is not column type. MEDIUM_BLOB field type is used to MEDIUM_TEXT column too.
You need to check charsetnr==63. (see this)
When filed type is BLOB and charsetnr != 63, it is TEXT column.
When filed type is BLOB and charsetnr == 63, it is BLOB column.
There was a problem hiding this comment.
Thank you for your review.
I understand that field type BLOB include both TEXT and BLOB data type.
Currently, mysql-connector-python drop charsetnr info at parse column-packet. (https://github.com/mysql/mysql-connector-python/blob/master/lib/mysql/connector/protocol.py#L279)
I think it is too big impact to change the structure of column info tuple for this issue.
So I only remove field type checking.
Fallback processing is an alternative checking charsetnr.
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
This PR fix BUG96280: When fetching binary result (include BLOB, VARBINARY data type) from a prepared cursor, UnicodeDecodeError has occurred.
What’s change?