Skip to content

Update charset/collation description indicate this is 16-bits, not 8-bits. #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update charset/collation description indicate this is 16-bits, not 8-bits. #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mysql-connector-python/lib/mysql/connector/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def setup_ssl(
host: Server host name.
ssl_options: SSL and TLS connection options (see
`network.MySQLSocket.build_ssl_context`).
charset: Client charset (see [1]), only the lower 8-bits.
charset: Client collation (see [1]).
client_flags: Integer representing client capabilities flags.
max_allowed_packet: Maximum packet size.

Expand Down Expand Up @@ -316,7 +316,7 @@ def authenticate(
password2: Account's password factor 2.
password3: Account's password factor 3.
database: Initial database name for the connection.
charset: Client charset (see [1]), only the lower 8-bits.
charset: Client collation (see [1]).
client_flags: Integer representing client capabilities flags.
max_allowed_packet: Maximum packet size.
auth_plugin: Authorization plugin name.
Expand Down
4 changes: 2 additions & 2 deletions mysql-connector-python/lib/mysql/connector/protocol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def make_auth(
username: Account's username.
password: Account's password.
database: Initial database name for the connection
charset: Client charset (see [2]), only the lower 8-bits.
charset: Client collation (see [2]).
client_flags: Integer representing client capabilities flags.
max_allowed_packet: Maximum packet size.
auth_plugin: Authorization plugin name.
Expand Down Expand Up @@ -415,7 +415,7 @@ def make_auth_ssl(
"""Make a SSL authentication packet (see [1]).

Args:
charset: Client charset (see [2]), only the lower 8-bits.
charset: Client collation (see [2]).
client_flags: Integer representing client capabilities flags.
max_allowed_packet: Maximum packet size.

Expand Down