Optimize on_secret_create & on_innodbcluster_field_backup_schedules handlers #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the original register handlers all secrets' creation or updating events, then kopf framework transfer ever log to k8s event, which overdriving the etcd, in some case this would even trigger OOM on etcd server.
when the InnoDBCluster is not created this handler also generates lots of events, I think we should involve a handler dynamically.
|
Update log message |
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
|
missing a fix on [sidecar] |
|
My Agreements: |
|
Hi, there was no response to our request to sign an OCA or confirm the code is submitted under the terms of the OCA. As such this request will be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize on_secret_create handler:
the original register handlers all secrets' creation or updating events, then kopf framework transfer every log to k8s event, which overdriving the etcd, in some case this would even trigger OOM on etcd server which cause the k8s master break down.
Optimize on_innodbcluster_field_backup_schedules handler:
when the InnoDBCluster is not created this handler also generates lots of events, I think we should involve a handler dynamically.
when the first InnoDBCluster created, then the handler registers.