Skip to content

Conversation

grooverdan
Copy link

@grooverdan grooverdan commented Dec 21, 2016

Thanks @bjornmu for feedback (#116 (comment)). Here is the check requested.

As per http://perldoc.perl.org/functions/-X.html -l will return false where not supported by OS so this should still work on Windows.

I note also on my Fedora based distro that /run/user/1000 is a shm too. The following may be added as well.

edit: /run/user/1000 isn't that good of a choice. Other locations are bigger.

$ df -h /dev/shm
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           3.8G  154M  3.6G   5% /dev/shm
$ df -h /run/user/1000/
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           766M   28K  766M   1% /run/user/1000
$ df -h /tmp
Filesystem      Size  Used Avail Use% Mounted on
tmpfs           3.8G  3.0G  850M  78% /tmp

@grooverdan
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow
bug http://bugs.mysql.com/bug.php?id=84299 for updates.
Thanks

@bjornmu
Copy link
Member

bjornmu commented Dec 30, 2016

Whether -l "works" on Windows is actually irrelevant since --mem is not supported on Windows in the first place, it's ignored. But it doesn't hurt to double check anyway. :-)

gunnarku pushed a commit to facebook/mysql-8.0 that referenced this pull request Jul 21, 2017
Summary:
MyRocks sometimes did merge sort, even with very small data sets.
This was very inefficient and was actually a cause of occasional
rocksdb_rpl.rpl_rocksdb_stress_crash test case failure (heap buffer
overflow reported via ASAN).

This diff adds estimate_rows_upper_bound() storage engine API,
just returning max bigint unsigned. By doing so, filesort always
checks sort buffer size and uses in memory sort when possible.

Test Plan:
mtr and verified rocksdb_rpl.rpl_rocksdb_stress_crash never
crashed. And added issue117 test case.

Reviewers: hermanlee4, jkedgar, spetrunia

Reviewed By: spetrunia

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D51639
gunnarku pushed a commit to facebook/mysql-8.0 that referenced this pull request Jul 25, 2017
Summary:
MyRocks sometimes did merge sort, even with very small data sets.
This was very inefficient and was actually a cause of occasional
rocksdb_rpl.rpl_rocksdb_stress_crash test case failure (heap buffer
overflow reported via ASAN).

This diff adds estimate_rows_upper_bound() storage engine API,
just returning max bigint unsigned. By doing so, filesort always
checks sort buffer size and uses in memory sort when possible.

Test Plan:
mtr and verified rocksdb_rpl.rpl_rocksdb_stress_crash never
crashed. And added issue117 test case.

Reviewers: hermanlee4, jkedgar, spetrunia

Reviewed By: spetrunia

Subscribers: webscalesql-eng

Differential Revision: https://reviews.facebook.net/D51639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants