Skip to content

mtr: Increase limit on parallel workers in mysql-test-run #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

mtr: Increase limit on parallel workers in mysql-test-run #33

wants to merge 1 commit into from

Conversation

grooverdan
Copy link

Parallel workers of the mysql-test-run has an artificial limit of 50 workers. On some hardware more CPUs are present. Running on such a hardware bot runs out of unique build thread ids

build@2b2bb0db98a7:~/build/mysql-test$ export MTR_MAX_PARALLEL=900
build@2b2bb0db98a7:~/build/mysql-test$ export MTR_PARALLEL=auto
build@2b2bb0db98a7:~/build/mysql-test$ ./mtr 2>&1 | tee /tmp/mtr.log
2015-12-10 03:33:53 0 [Note] /build/build/sql/mysqld (mysqld 5.6.27) starting as process 78806 ...
2015-12-10 03:33:53 78806 [Note] Plugin 'FEDERATED' is disabled.
2015-12-10 03:33:53 78806 [Note] Binlog end
2015-12-10 03:33:53 78806 [Note] Shutting down plugin 'MyISAM'
2015-12-10 03:33:53 78806 [Note] Shutting down plugin 'CSV'
MySQL Version 5.6.27
Checking supported features...
 - SSL connections supported
Using suites: main,sys_vars,binlog,federated,rpl,innodb,innodb_fts,innodb_zip,perfschema,funcs_1,opt_trace,parts,auth_sec
Collecting tests...
 - adding combinations for binlog
 - adding combinations for rpl
Checking leftover processes...
Removing old var directory...
Creating var directory '/build/build/mysql-test/var'...
Installing system database...
Using parallel: 161
worker[2] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
worker[3] Using MTR_BUILD_THREAD 304, with reserved ports 13040..13049
worker[4] Using MTR_BUILD_THREAD 303, with reserved ports 13030..13039
worker[14] Using MTR_BUILD_THREAD 305, with reserved ports 13050..13059
worker[6] Using MTR_BUILD_THREAD 302, with reserved ports 13020..13029
worker[1] Using MTR_BUILD_THREAD 301, with reserved ports 13010..13019
worker[15] Using MTR_BUILD_THREAD 306, with reserved ports 13060..13069
...
...
...
worker[38] Using MTR_BUILD_THREAD 348, with reserved ports 13480..13489
worker[35] Using MTR_BUILD_THREAD 345, with reserved ports 13450..13459
worker[44] mysql-test-run: *** ERROR: Could not get a unique build thread id
worker[49] mysql-test-run: *** ERROR: Could not get a unique build thread id
worker[74] mysql-test-run: *** ERROR: Could not get a unique build thread id
worker[75] mysql-test-run: *** ERROR: Could not get a unique build thread id
worker[63] mysql-test-run: *** ERROR: Could not get a unique build thread id
....

@grooverdan
Increase limit on parallel workers in mysql-test-run
2475bc2 
Signed-off-by: Daniel Black <daniel.black@au.ibm.com>
@grooverdan
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@ghost
Copy link

ghost commented Dec 10, 2015

Looks good to me, even though it's been a few years since I was mtr hacking :)

Should possibly try this on the 4 socket box we have in the lab too... 320 threads would be a bit of a test.

Reviewed-by: Stewart Smith stewart@linux.vnet.ibm.com

@mysql-oca-bot
Copy link

Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at http://www.oracle.com/technetwork/community/oca-486395.html
Please make sure to include your MySQL bug system user (email) in the returned form.
Thanks

@grooverdan
Copy link
Author

bug reported https://bugs.mysql.com/?id=79585 (sorry oca-bot - too slow)

OCA being sorted out out of band.

@mysql-oca-bot
Copy link

Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment:
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."
Thanks

@grooverdan
Copy link
Author

I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

@mysql-oca-bot
Copy link

Hi, the OCA associated with the owner of the this pull request has been cancled. As such this request will be closed. Thanks

@grooverdan grooverdan mentioned this pull request Mar 30, 2016
Closed
gunnarku pushed a commit to facebook/mysql-8.0 that referenced this pull request Jul 21, 2017
@spetrunia
Issue mysql#33: SELECT ... FROM rocksdb_table ORDER BY primary_key us…
d385097 
…es sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Test Plan: mtr

Reviewers: maykov, jonahcohen, hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: jtolmer

Differential Revision: https://reviews.facebook.net/D33957
gunnarku pushed a commit to facebook/mysql-8.0 that referenced this pull request Jul 25, 2017
@spetrunia
Issue mysql#33: SELECT ... FROM rocksdb_table ORDER BY primary_key us…
f32361f 
…es sorting

Summary:
Fix the index properties returned by the storage engine:
- ha_rocksdb::primary_key_is_clustered()= true;
- ha_rocksdb::keys_to_use_for_scanning()= &key_map_full;

Test Plan: mtr

Reviewers: maykov, jonahcohen, hermanlee4, yoshinorim

Reviewed By: yoshinorim

Subscribers: jtolmer

Differential Revision: https://reviews.facebook.net/D33957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grooverdan @mysql-oca-bot