Fix operator name keywords causing obscure errors on -fno-operator-names #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-names
Alternative operator name keywords like `and`, `or`, `xor`, etc., are
rarely used in MySQL and can cause obscure errors when the GCC flag
`-fno-operator-names` is applied, for example:
```
/MySQL/storage/temptable/include/temptable/lock_free_type.h:125:75: error: template argument 2 is invalid
125 | std::is_trivially_copyable<T>::value>::type> {
| ^
/MySQL/storage/temptable/include/temptable/lock_free_type.h:148:19: error: parse error in template argument list
148 | typename std::enable_if<std::is_same<T, long long>::value or
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
149 | std::is_same<T, unsigned long long>::value>::type> {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Replace the few occurrences of operator name keywords to use their
primary counter parts, like `&&`, `||`, and `!`.
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
This contribution is under the OCA signed by Amazon and covering submissions to the MySQL project. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative operator name keywords like
and,or,xor, etc., are rarely used in MySQL and can cause obscure errors when the GCC flag-fno-operator-namesis applied, for example:Replace the few occurrences of operator name keywords to use their primary counter parts, like
&&,||, and!.