BUG #96310 INSERT accepts invalid date from default val With Binlog Open #617
Conversation
PROBLEM: -------- When variable 'log_bin' is ON (that is, mysql will generate binary log for DML query) some invalid date from default value will be accepted by mysql. Repeat: SET sql_mode=''; CREATE TABLE default_date(a DATE NOT NULL DEFAULT '0000-00-00'); SET sql_mode=default; INSERT INTO default_date VALUES(); -- invalid data will be accepted. Solution: -------- We need not mark_columns_per_binlog_row_image IN TABLE::mark_columns_needed_for_insert, which is unnecessary and will change table->write_set and validate_default_values_of_unset_fields will skip data check finally fix
beifangxiuwhx
force-pushed
the
dev-fix-bug-96310
branch
from
1efe748 to
6134c5a
Compare
|
Hi, thank you for submitting this pull request. In order to consider your code we need you to sign the Oracle Contribution Agreement (OCA). Please review the details and follow the instructions at https://oca.opensource.oracle.com/ |
I have signed OCA and my account in Oracle is kindaichweng@gmail.com |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
"I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it." |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
Bugfix for https://bugs.mysql.com/bug.php?id=96310
I have signed OCA and my account in Oracle is kindaichweng@gmail.com
PROBLEM:
When variable 'log_bin' is ON (that is, mysql will generate binary log for DML query) some invalid date from default value will be accepted by mysql.
Repeat:
SET sql_mode='';
CREATE TABLE default_date(a DATE NOT NULL DEFAULT '0000-00-00');
SET sql_mode=default;
INSERT INTO default_date VALUES(); -- invalid data will be accepted.
Solution:
We need not mark_columns_per_binlog_row_image IN TABLE::mark_columns_needed_for_insert, which is unnecessary and will change table->write_set and validate_default_values_of_unset_fields will skip data check finally