[BUG-95158] Improve control file #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution. Please confirm this code is submitted under the terms of the OCA (Oracle's Contribution Agreement) you have previously signed by cutting and pasting the following text as a comment: |
|
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it. |
|
Hi, thank you for your contribution. Your code has been assigned to an internal queue. Please follow |
nawazn
pushed a commit
that referenced
this pull request
Jul 22, 2019
This push introduces the following enhancements to the help system: 1) Adds member naming style resolution even for Doxygen generated help. 2) Adds support for <br> in shell help. 3) Replaces <code></code> for @code @Endcode Collateral change: detected that <code> was being used in a wrong way to create a hardcoded formatting on the Command Line integration help. Have reformatted that help to use standard formating. Naming Style Resolution in Doxygen ---------------------------------- Resolution of member names has been supported in the shell help by simply enclosing the member name as <<<camelCaseMemberName>>>. However this did not work for Doxygen and we ended adding chunks of help defined between DOXYGEN_JS/DOXYGEN_PY whenever we wanted to refer to another member on the help. Now this resolution also works for Doxygen as long as it is defined in any of the REGISTER_*HELP* macros, this is, does not work if using <<<>>> directly in doxygen comments. Support for <br> ---------------- This is simply handy, it will be rendered as a new line character on the shell help. New Code Commands ----------------- It was detected that <code></code> were not achieving the desired effect in the Doxygen docs (which is creating a code snippet). For this reason we have replaced it in the shell to use @code and @Endcode commands instead. Suggestion that whenever @code is required, the help is registered using the new REGISTER_*HELP* macros that allow defining the entire help in a multiline text definition, reason for this is because whatever spacing you use, it will be rendered that way with no extra effort. If not done that way you will have to give the desired formatting to the text, i.e. adding new lines, using  , etc. For examples about #1 look at the changes in mod_shell.cc For examples about #3 the good way, look at the changes in mod_mysqlx_collection.cc For examples about #4 the bad way, look at the changes in mod_util.cc Change-Id: I50e0812d86efa528abde8c690d96157c103ac66d
dveeden
pushed a commit
to dveeden/mysql-shell
that referenced
this pull request
Dec 8, 2020
Automatic use of prepared statements for SQL and CRUD statements through the X protocol is introduced by this patch as follows: 1) Any statement will execute normally the first time, when executed a second time (without changes on the statement), it will be prepared and then executed; additional executions will use the prepared statement. 2) If the statement changes the previous logic will restart. 3) Any call to a chained function causes the statement to change except for calls to limit(), offset(), bind() or execute() (as applicable). These means, those functions should be reusable even on a prepared statement, reusing it. 4) If the target server does not support prepared statements, it should be detected the first time and the prepared statement logic should no longer be used with that session. To achieve mysql#3 a refactoring was required on the way the chained functions are enabled/disabled. Now when the dynamic behavior is registered for a function, it is required to indicate: a) Functions that should be enabled after calling a function, default none. b) Functions that should be disabled after calling a function, default none. c) If the function can be called many times, default false. This patch also removes left over files for collection index creation which was converted to a single function (not chainable) on the Collection class a couple of releases ago. Change-Id: Iadfd034abcb068789155b77820eb89458691efad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case if DEB_DEPS and/or DEB_BUILD_DEPS are empty there will be an empty lines in control file.
This empty lines will generate an issue during deb build
syntax error in debian/control at line 21: block lacks the 'Package' field