Skip to content

Fix version check for 8.1+ #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix version check for 8.1+ #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/python/workbench/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def __le__(self, other):
return self.compare(other) <= 0

def is_supported_mysql_version(self):
if (self.majorNumber == 5 and self.minorNumber in (1, 5, 6, 7)) or (self.majorNumber == 8 and self.minorNumber == 0):
if (self.majorNumber == 5 and self.minorNumber in (1, 5, 6, 7)) or (self.majorNumber == 8):
return True
return False

Expand All @@ -228,7 +228,7 @@ def is_supported_mysql_version_at_least(self, major, minor = None, release=-1):
# if the version required is older (<) than 5.6, then any server that matches is fine
# if the version required is newer (>=) than 5.6, then we can only guarantee that known servers versions have some specific feature

if (major == 5 and minor >= 6) or (major == 8 and minor == 0):
if (major == 5 and minor >= 6) or (major == 8):
return self.is_supported_mysql_version() and self >= Version(major, minor, release)
else:
return self > Version(major, minor, release)
Expand Down