-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add .query to PoolNamespace. #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
now we can use cluster this way: var pool = cluster.of('SLAVE*', 'ORDER');
pool.query('SELECT 1', function (err, rows) {}) // works fine!! |
travis ci fails, but seems a old test result in that. |
Nice, thanks, @alsotang! Don't worry about that failing test; I'll get it fixed today :) |
Sorry for the long delay, @alsotang ! I was able to fix the flaky tests, and so the PR is now passing the tests. I do see that the PR is marked failing as well because it caused the coverage percentage to decrease. Looking at the report, it looks like it's because in the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending tests for new code paths. The only missing ones are displayed at https://coveralls.io/builds/7620472/source?filename=lib%2FPoolNamespace.js
…ut still backward-compatible
b545519
to
4e79b2a
Compare
lol @alsotang I just popped into this PR to see if I could just add the tests & merge to help out :) I see you just put more more commits. Please ping me when you're ready for me to take a look :) |
I already add tests for the error handler. Seems now the |
Refactor PoolNamespace#_getClusterNode but still backward-compatible
original issue: #1505