-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Physical Review Journals tex template #23
Add Physical Review Journals tex template #23
Conversation
Thanks for coming to the webinar, let us know where you get to with this over the next few days and then we can start to jump in and help or develop any missing pieces. |
@rowanc1 I have updated the repository and it looks already promising. I still need to work on the following topics:
Maybe there are more points, but these are the ones that I will address first. |
I have updated the template repository. I think that I have reached a state where we can start a review process. From the points mentioned above I have managed 2., 3. and 4. Concerning 1. I have tried to use the affiliations on the Which publication can we use to for an example publication written with the template? Shall I create issues in my repository for the open issues I have mentioned in the README? |
@dressedfez great - let me take a look and see if I can assist! |
@dressedfez on the |
@stevejpurves have you found any time to review the template? When you find time for the review it would be great if you could answer myst-templates/physical_review_journals#9. I will try to close the remaining issues in the coming days. |
@dressedfez the example builds nicely for me - I note that the repo does have a thumbnail.png already 👍🏼 but the checkbox isn't ticked on the README yet. Out of the open issues; I am looking at upstream changes to support 1 and 12 -- out of the other issues, @dressedfez what is the shortlist that you want to see resolved before adding this to the index |
Supporting 1 und 12 would already be great. Concerning the rest I have the following idea. Myst already supports Do you think it is possible to re-use the work of the I would say that the main work on the template is done to add it to the index. |
Is the restriction mentioned here: https://myst-tools.org/docs/jtex/template-yml#template-files strict? Especially the statement: |
I thought this might have been addressed in: |
I think I have found something concerning this topic. Please have a look here: jupyter-book/mystmd#84 (comment). To me it seems that this is as @fwkoch writes: Maybe we have here a valid situation that would render us to break this restriction. |
Hey, yeah - I still agree with my past comment but it does require a bit of work to break this restriction. I made a specific issue for it here: jupyter-book/mystmd#420 For now, I guess we just keep copying files to the root directory when necessary... |
Other than that I've played with some options and cross checked the And sorry it's taken so long to get a review back to you 🙏🏼, once we're happy with the above we can merge this |
Understandable decision. Following this I will create for each journal (PRL, PRA, etc) an own template which will contain a copy of the |
I will contact you when I'm done with the requested changes. I'm currently busy so it might take as well a week or more. |
@dressedfez just to clarify, point 2 is moot, that's fine :) and points 1 & 3 are questions/suggestions rather than requests. I'd be interested to just know what you think especially on the whitespace? and i'm happy to quickly make the changes and open a PR if you're happy with my suggestions |
Just go ahead with the PR |
This provides the initial version of the LaTex template for Physical Review Journal articles associated to the
American Physical Society (see https://journals.aps.org/about).