-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paul/auto docker #27
Paul/auto docker #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like a great start. Some general questions from me.
@bjornaer from your two comment threads I see that you want to include more thing in the Pipeline top level class and direct the user to use most low level features through there. Personally I'm not a fan of this and I think long term it will bulk up the Class, if not in the short-term. I do have a preference to keep things separate: if you want to create a docker API then you go to a docker object, if you want to talk to PipelineCloud then you talk to the PipelineCloud object. So from here I think we should setup a meeting (with @alexpearce) to discuss how much we want to include in the Pipeline class; but for the moment I think we should merge this PR and then add in the adjustments later based on the outcomes of that meeting, how does this sound? I'm also suggesting this as your comments are for additions rather than adjustments on the changes I've added. |
alright, I am resolving the convos, please setup a meeting for us to talk about it! |
No description provided.