Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Top URL #29

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Correct Top URL #29

merged 1 commit into from
Jan 31, 2022

Conversation

alexpearce
Copy link
Contributor

The trailing slash results in a redirect response, but the redirect doesn't include the Authorization header in production so causes 403 errors.

(Most Top URLs do not end in a slash; POST /v2/files/ is one exception I know of, there may be others)

@alexpearce alexpearce requested a review from bjornaer January 20, 2022 15:38
bjornaer
bjornaer previously approved these changes Jan 24, 2022
bjornaer
bjornaer previously approved these changes Jan 31, 2022
Copy link
Contributor

@bjornaer bjornaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the code to pass linting
LGTM

@alexpearce alexpearce merged commit d03e113 into main Jan 31, 2022
@alexpearce alexpearce deleted the apearce-top-url branch January 31, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants