Set Function's local ID on creation from remote schema #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading a Pipeline looks like:
Function
objects.local_id
of eachFunction
object with the remote ID.Model
andVariable
).GraphNode
and outputVariable
)Pipeline
schema.I think there is a bug when resurrecting a Pipeline. The graph nodes will contain the remote
Function
IDs thanks to step 2 above, however theFunction
objects resurrected from the schemas will not have the remote ID as they are uploaded before the replacement. This causes the function search to fail because_node.function
is a remote ID whereas_func.local_id
is a local one.This PR is one possible fix: when resurrecting a
Function
from a schema, override the deserialisedlocal_id
with the (remote!) ID included in the schema.