PC-1044 Streaming runs #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossgray
reviewed
Mar 12, 2024
* stream post run query function * add stream runio type + RunResult type * track streaming indices and weather streaming required * handle new streaming chunk * integrate streaming into playground * remove stray console logs * frontend build
rossgray
reviewed
Mar 12, 2024
|
@paulcjh I wonder if we should make the streaming endpoint in the container a separate endpoint, as we're doing with the backend API, since previously we've tried to keep |
* update stream function to accumulate chunks until valid json * integrate image streaming into playground. Note this may break for other run types * build frontend
* custom pipeline run output column with tooltip and dropdown streaming mode select * integrate into playground * frontend build
|
the only other thought I had (and maybe we can always do this later) was whether it makes sense to return the full run result schema every time, or just the raw outputs? Since I have a feeling all of the serialising JSON in and out of Pydantic objects may add a bit of overhead. We could always add a separate endpoint for that later though. Maybe also an endpoint where the results are streamed directly from the resource too without going via catalyst and pcore |
* made streaming mode dropdown styling a bit better * added frontend build js
* unnest streamPostRun * rudimentary implementation of chat interface with streaming * add responseTime + fix localStorage saving * refactor streaming index logic into hook * fix undefined in new hook * make chat both stream and non stream compatible * build frontend
* fixes * Making streaming response more robust * Create helper function for handling stream responses * Add async version of helper func * Small tweaks * improve error handling * cleanup
* port over markdown component from dashboard * render markdown in chat messages * build frontend
* Move Stream class into diff module * Move stream run into its own route * cleanup * blacken
plutopulp
force-pushed
the
ph/pc-1044-streaming-runs
branch
2 times, most recently
from
d4e2b29 to
131f593
Compare
* Small refactor * Add test * Add pytest-asyncio dependency * Fix ordering of outputs * formatting * fix formatting in other file
plutopulp
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request outline
Checklist:
Added:
Changed:
Removed:
Related issues:
none