Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC-1062 - Improve error handling in stream endpoint #443

Merged
merged 4 commits into from
Mar 20, 2024
Merged

PC-1062 - Improve error handling in stream endpoint #443

merged 4 commits into from
Mar 20, 2024

Conversation

rossgray
Copy link
Contributor

@rossgray rossgray commented Mar 20, 2024 •
edited
Loading

Pull request outline

Ensure any exceptions raised during pipeline execution get reported correctly by the stream endpoint.

Also add a custom streaming response class for reporting status codes from iterated content.

Checklist:

  • Docs updated
  • Tests written
  • Check for breaking changes in Resource
  • Version bumped

Added:

  • A list of new things

Changed:

  • A list of things changed

Removed:

  • A list of things removed

Related issues:

none

  • You can add a reference to an issue using hash followed by the issue number
  • If a checklist item is to be ignored it must be struck through

@linear Linear
Copy link

linear bot commented Mar 20, 2024

PC-1062 Improve error handling in stream endpoint

@rossgray rossgray force-pushed the ross/pc-1062-improve-error-handling-in-stream-endpoint branch from 1958204 to fe249be Compare March 20, 2024 16:44
plutopulp
plutopulp approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@plutopulp plutopulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossgray rossgray merged commit 7a06c4a into main Mar 20, 2024
5 checks passed
@rossgray rossgray deleted the ross/pc-1062-improve-error-handling-in-stream-endpoint branch March 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plutopulp plutopulp plutopulp approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossgray @plutopulp