Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change cluster schmea on pipeline get #450

Merged
merged 4 commits into from
Apr 29, 2024
Merged

change cluster schmea on pipeline get #450

merged 4 commits into from
Apr 29, 2024

Conversation

plutopulp
Copy link
Contributor

@plutopulp plutopulp commented Apr 26, 2024 •
edited
Loading

Update the cluster response schema tied to a pipeline. Change should be backwards compatible.

@plutopulp plutopulp requested a review from MPCherry April 26, 2024 14:32
@plutopulp plutopulp marked this pull request as ready for review April 29, 2024 11:30
rossgray
rossgray approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@rossgray rossgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a non-blocking comment

@plutopulp plutopulp merged commit 0e5baa4 into main Apr 29, 2024
5 checks passed
@plutopulp plutopulp deleted the plutopulp/pipeline-cluster-schema-tweak branch April 29, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossgray rossgray rossgray approved these changes

@MPCherry MPCherry Awaiting requested review from MPCherry

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plutopulp @rossgray