Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish current run from v4/container/state endpoint #476

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

rossgray
Copy link
Contributor

@rossgray rossgray commented Jul 30, 2024

Pull request outline

As well as publishing the current run, there are a few more changes in here (looking at the commits individually will help review):

  • refactor the execution_handler slightly
    • move into a run services module
    • it now returns the result and status code rather than just the result
  • update a few dependencies (including httpx)
  • update the tests
    • needed to use an async client in order to mock certain behaviour (if we don't use an async client we get issues mocking things as they run in a different event loop to the API)

Checklist:

  • Tests written
  • Version bumped

Copy link

linear bot commented Jul 30, 2024

@plutopulp plutopulp self-requested a review July 30, 2024 13:52
Copy link
Contributor

@plutopulp plutopulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although maybe another pair of eyes may be good as not super familiar with the code.

@rossgray rossgray merged commit 32382ba into main Jul 30, 2024
5 checks passed
@rossgray rossgray deleted the ross/pc-1176-publish-current-run-from-resource-monitor branch July 30, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants